[Mlir-commits] [mlir] e44a3c3 - [mlir][doc] Update op optional-group asm format doc

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Oct 31 07:34:59 PDT 2022


Author: rkayaith
Date: 2022-10-31T10:34:53-04:00
New Revision: e44a3c3d7f7de687acd98fec26086d6cb56a450c

URL: https://github.com/llvm/llvm-project/commit/e44a3c3d7f7de687acd98fec26086d6cb56a450c
DIFF: https://github.com/llvm/llvm-project/commit/e44a3c3d7f7de687acd98fec26086d6cb56a450c.diff

LOG: [mlir][doc] Update op optional-group asm format doc

Update docs to describe the behaviour when a default-valued attribute is
used as an optional-group's anchor after D134993.

Reviewed By: Mogball

Differential Revision: https://reviews.llvm.org/D136987

Added: 
    

Modified: 
    mlir/docs/OpDefinitions.md

Removed: 
    


################################################################################
diff  --git a/mlir/docs/OpDefinitions.md b/mlir/docs/OpDefinitions.md
index 5f34614cade02..3acbf8360f64d 100644
--- a/mlir/docs/OpDefinitions.md
+++ b/mlir/docs/OpDefinitions.md
@@ -878,8 +878,9 @@ The elements of an optional group have the following requirements:
         the group is if the region is empty.
 *   Literals, variables, custom directives, and type directives are the only
     valid elements within the group.
-    -   Any attribute variable may be used, but only optional attributes can be
-        marked as the anchor.
+    -   Any attribute variable may be used, but only optional or default-valued
+        attributes can be marked as the anchor. A default-valued anchor is
+        considered present if it holds a value other than the default.
     -   Only variadic or optional results and operand arguments and can be used.
     -   All region variables can be used. When a non-variable length region is
         used, if the group is not present the region is empty.


        


More information about the Mlir-commits mailing list