[Mlir-commits] [mlir] 764c712 - [mlir][spirv] fix Bazel build of Passes.h

Emilio Cota llvmlistbot at llvm.org
Thu Oct 27 18:50:47 PDT 2022


Author: Emilio Cota
Date: 2022-10-27T21:47:50-04:00
New Revision: 764c7128c01657d255352f8894c10338aeffc7cd

URL: https://github.com/llvm/llvm-project/commit/764c7128c01657d255352f8894c10338aeffc7cd
DIFF: https://github.com/llvm/llvm-project/commit/764c7128c01657d255352f8894c10338aeffc7cd.diff

LOG: [mlir][spirv] fix Bazel build of Passes.h

I cannot repro this with CMake, but on Bazel this is failing with
```
error: incomplete result type 'mlir::spirv::TargetEnvAttr' in function definition
[...]
note: in instantiation of member function 'std::function<mlir::spirv::TargetEnvAttr (mlir::spirv::ModuleOp)>::function' requested here
createUnifyAliasedResourcePass(GetTargetEnvFn getTargetEnv = nullptr);
```

Reviewed By: antiagainst

Differential Revision: https://reviews.llvm.org/D136909

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/SPIRV/Transforms/Passes.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/SPIRV/Transforms/Passes.h b/mlir/include/mlir/Dialect/SPIRV/Transforms/Passes.h
index f718d52dcf743..7c9fc592430b1 100644
--- a/mlir/include/mlir/Dialect/SPIRV/Transforms/Passes.h
+++ b/mlir/include/mlir/Dialect/SPIRV/Transforms/Passes.h
@@ -13,6 +13,7 @@
 #ifndef MLIR_DIALECT_SPIRV_TRANSFORMS_PASSES_H_
 #define MLIR_DIALECT_SPIRV_TRANSFORMS_PASSES_H_
 
+#include "mlir/Dialect/SPIRV/IR/SPIRVAttributes.h"
 #include "mlir/Pass/Pass.h"
 
 namespace mlir {
@@ -22,7 +23,6 @@ class ModuleOp;
 namespace spirv {
 
 class ModuleOp;
-class TargetEnvAttr;
 
 //===----------------------------------------------------------------------===//
 // Passes


        


More information about the Mlir-commits mailing list