[Mlir-commits] [mlir] 5fcf3e8 - [mlir][spirv] Flip createConvertGPUToSPIRVPass mapMemorySpace default

[Lei Zhang]

Author: jackalcooper
Date: 2022-10-26T11:09:28-04:00
New Revision: 5fcf3e8b4e90b24e49e25766e63fb4e1803582a9

URL: https://github.com/llvm/llvm-project/commit/5fcf3e8b4e90b24e49e25766e63fb4e1803582a9
DIFF: https://github.com/llvm/llvm-project/commit/5fcf3e8b4e90b24e49e25766e63fb4e1803582a9.diff

LOG: [mlir][spirv] Flip createConvertGPUToSPIRVPass mapMemorySpace default

Some down-stream libraries only have access to CAPI, setting
default value of mapMemorySpace to true will help them convert IR
to SPIR-V.

Reviewed By: antiagainst

Differential Revision: https://reviews.llvm.org/D136739

Added: 
    

Modified: 
    mlir/include/mlir/Conversion/GPUToSPIRV/GPUToSPIRVPass.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Conversion/GPUToSPIRV/GPUToSPIRVPass.h b/mlir/include/mlir/Conversion/GPUToSPIRV/GPUToSPIRVPass.h
index c091a71630f1..b1a6de011111 100644
--- a/mlir/include/mlir/Conversion/GPUToSPIRV/GPUToSPIRVPass.h
+++ b/mlir/include/mlir/Conversion/GPUToSPIRV/GPUToSPIRVPass.h
@@ -29,7 +29,7 @@ class OperationPass;
 /// If `mapMemorySpace` is true, performs MemRef memory space to SPIR-V mapping
 /// according to default Vulkan rules first.
 std::unique_ptr<OperationPass<ModuleOp>>
-createConvertGPUToSPIRVPass(bool mapMemorySpace = false);
+createConvertGPUToSPIRVPass(bool mapMemorySpace = true);
 
 } // namespace mlir
 #endif // MLIR_CONVERSION_GPUTOSPIRV_GPUTOSPIRVPASS_H