[Mlir-commits] [mlir] 877977b - [mlir][llvm] Fix replaceImmediateSubElements on LLVMPointerType

Jeff Niu llvmlistbot at llvm.org
Fri Oct 21 15:13:23 PDT 2022


Author: Jeff Niu
Date: 2022-10-21T15:13:09-07:00
New Revision: 877977bba966e3306dae28d06cfd41b64968f267

URL: https://github.com/llvm/llvm-project/commit/877977bba966e3306dae28d06cfd41b64968f267
DIFF: https://github.com/llvm/llvm-project/commit/877977bba966e3306dae28d06cfd41b64968f267.diff

LOG: [mlir][llvm] Fix replaceImmediateSubElements on LLVMPointerType

This method was assearting on opaque pointers because the element is
null.

Depends on D136498

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D136499

Added: 
    

Modified: 
    mlir/lib/Dialect/LLVMIR/IR/LLVMTypes.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/LLVMIR/IR/LLVMTypes.cpp b/mlir/lib/Dialect/LLVMIR/IR/LLVMTypes.cpp
index 85e439185d8c..f37247331689 100644
--- a/mlir/lib/Dialect/LLVMIR/IR/LLVMTypes.cpp
+++ b/mlir/lib/Dialect/LLVMIR/IR/LLVMTypes.cpp
@@ -450,7 +450,7 @@ void LLVMPointerType::walkImmediateSubElements(
 
 Type LLVMPointerType::replaceImmediateSubElements(
     ArrayRef<Attribute> replAttrs, ArrayRef<Type> replTypes) const {
-  return get(replTypes.front(), getAddressSpace());
+  return get(getContext(), replTypes.front(), getAddressSpace());
 }
 
 //===----------------------------------------------------------------------===//


        


More information about the Mlir-commits mailing list