[Mlir-commits] [mlir] 8383970 - [mlir][sparse] Restore case coverage warning fix

[Stella Stamenova]

Author: Nathaniel McVicar
Date: 2022-10-04T09:59:20-07:00
New Revision: 83839700c32996c58ddebc0c74e3dc4970e005bc

URL: https://github.com/llvm/llvm-project/commit/83839700c32996c58ddebc0c74e3dc4970e005bc
DIFF: https://github.com/llvm/llvm-project/commit/83839700c32996c58ddebc0c74e3dc4970e005bc.diff

LOG: [mlir][sparse] Restore case coverage warning fix

This restores the fix from D134925 to make MSVC and clang happy.

Reviewed By: stella.stamenova

Differential Revision: https://reviews.llvm.org/D135126

Added: 
    

Modified: 
    mlir/lib/ExecutionEngine/SparseTensor/File.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/ExecutionEngine/SparseTensor/File.cpp b/mlir/lib/ExecutionEngine/SparseTensor/File.cpp
index eac3b0278ce3..b2632313f7d3 100644
--- a/mlir/lib/ExecutionEngine/SparseTensor/File.cpp
+++ b/mlir/lib/ExecutionEngine/SparseTensor/File.cpp
@@ -24,6 +24,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "mlir/ExecutionEngine/SparseTensor/File.h"
+#include "llvm/Support/ErrorHandling.h"
 
 #include <cctype>
 #include <cstring>
@@ -108,6 +109,7 @@ bool SparseTensorFile::canReadAs(PrimaryType valTy) const {
     // integer and floating primary-types.
     return isRealPrimaryType(valTy);
   }
+  llvm_unreachable("unknown ValueKind");
 }
 
 /// Helper to convert C-style strings (i.e., '\0' terminated) to lower case.