[Mlir-commits] [mlir] d62d278 - [mlir][sparse] Misc cleanup of MLIRSparseTensorRuntime

[wren romano]

Author: wren romano
Date: 2022-11-16T16:15:55-08:00
New Revision: d62d2783f7f6d8e18648732fd65a03bc414a4578

URL: https://github.com/llvm/llvm-project/commit/d62d2783f7f6d8e18648732fd65a03bc414a4578
DIFF: https://github.com/llvm/llvm-project/commit/d62d2783f7f6d8e18648732fd65a03bc414a4578.diff

LOG: [mlir][sparse] Misc cleanup of MLIRSparseTensorRuntime

Removing an unnecessary import, and renaming some macros to match the style used elsewhere.

Reviewed By: aartbik, bixia

Differential Revision: https://reviews.llvm.org/D138158

Added: 
    

Modified: 
    mlir/include/mlir/ExecutionEngine/SparseTensor/COO.h
    mlir/include/mlir/ExecutionEngine/SparseTensorRuntime.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/ExecutionEngine/SparseTensor/COO.h b/mlir/include/mlir/ExecutionEngine/SparseTensor/COO.h
index bbce69beeaaad..d004fe3e6ebb8 100644
--- a/mlir/include/mlir/ExecutionEngine/SparseTensor/COO.h
+++ b/mlir/include/mlir/ExecutionEngine/SparseTensor/COO.h
@@ -17,8 +17,6 @@
 #ifndef MLIR_EXECUTIONENGINE_SPARSETENSOR_COO_H
 #define MLIR_EXECUTIONENGINE_SPARSETENSOR_COO_H
 
-#include "mlir/ExecutionEngine/SparseTensor/PermutationRef.h"
-
 #include <algorithm>
 #include <cassert>
 #include <cinttypes>

diff  --git a/mlir/include/mlir/ExecutionEngine/SparseTensorRuntime.h b/mlir/include/mlir/ExecutionEngine/SparseTensorRuntime.h
index 32e6123651865..c16efccfb4333 100644
--- a/mlir/include/mlir/ExecutionEngine/SparseTensorRuntime.h
+++ b/mlir/include/mlir/ExecutionEngine/SparseTensorRuntime.h
@@ -244,12 +244,12 @@ MLIR_CRUNNERUTILS_EXPORT void _mlir_ciface_getSparseTensorReaderDimSizes(
 MLIR_CRUNNERUTILS_EXPORT void delSparseTensorReader(void *p);
 
 /// Returns the next element for the sparse tensor being read.
-#define IMPL_GETNEXT(VNAME, V)                                                 \
+#define DECL_GETNEXT(VNAME, V)                                                 \
   MLIR_CRUNNERUTILS_EXPORT void _mlir_ciface_getSparseTensorReaderNext##VNAME( \
       void *p, StridedMemRefType<index_type, 1> *iref,                         \
       StridedMemRefType<V, 0> *vref);
-MLIR_SPARSETENSOR_FOREVERY_V(IMPL_GETNEXT)
-#undef IMPL_GETNEXT
+MLIR_SPARSETENSOR_FOREVERY_V(DECL_GETNEXT)
+#undef DECL_GETNEXT
 
 using SparseTensorWriter = std::ostream;
 
@@ -269,12 +269,12 @@ MLIR_CRUNNERUTILS_EXPORT void _mlir_ciface_outSparseTensorWriterMetaData(
     StridedMemRefType<index_type, 1> *dref);
 
 /// Outputs an element for the sparse tensor.
-#define IMPL_OUTNEXT(VNAME, V)                                                 \
+#define DECL_OUTNEXT(VNAME, V)                                                 \
   MLIR_CRUNNERUTILS_EXPORT void _mlir_ciface_outSparseTensorWriterNext##VNAME( \
       void *p, index_type rank, StridedMemRefType<index_type, 1> *iref,        \
       StridedMemRefType<V, 0> *vref);
-MLIR_SPARSETENSOR_FOREVERY_V(IMPL_OUTNEXT)
-#undef IMPL_OUTNEXT
+MLIR_SPARSETENSOR_FOREVERY_V(DECL_OUTNEXT)
+#undef DECL_OUTNEXT
 
 } // extern "C"