[Mlir-commits] [mlir] 8474a20 - [mlir][sparse] bring CHECK tests back (but disabled)

[Aart Bik]

Author: Aart Bik
Date: 2022-11-16T07:55:50-08:00
New Revision: 8474a20b1f41c1576d8ec76040fb872b65b7db00

URL: https://github.com/llvm/llvm-project/commit/8474a20b1f41c1576d8ec76040fb872b65b7db00
DIFF: https://github.com/llvm/llvm-project/commit/8474a20b1f41c1576d8ec76040fb872b65b7db00.diff

LOG: [mlir][sparse] bring CHECK tests back (but disabled)

We have a strange nondeterministic failure on windows
by not getting the desired fill statement in the resulting
IR. Probably something wrong with our option passing or
pass construction?

https://github.com/llvm/llvm-project/issues/59016#issuecomment-1316410249

Reviewed By: bixia

Differential Revision: https://reviews.llvm.org/D138089

Added: 
    

Modified: 
    mlir/test/Dialect/SparseTensor/codegen_buffer_initialization.mlir

Removed: 
    


################################################################################
diff  --git a/mlir/test/Dialect/SparseTensor/codegen_buffer_initialization.mlir b/mlir/test/Dialect/SparseTensor/codegen_buffer_initialization.mlir
index dede407eda201..8054e541ec720 100644
--- a/mlir/test/Dialect/SparseTensor/codegen_buffer_initialization.mlir
+++ b/mlir/test/Dialect/SparseTensor/codegen_buffer_initialization.mlir
@@ -2,11 +2,14 @@
 
 #SV = #sparse_tensor.encoding<{ dimLevelType = [ "compressed" ] }>
 
+// FIXME: windows fails on the "CH__ECK" tests below, non-deterministically
+
 // CHECK-LABEL: func @sparse_alloc_sparse_vector(
 //  CHECK-SAME: %[[A:.*]]: index) ->
 //  CHECK-SAME: memref<1xindex>, memref<3xindex>, memref<?xindex>, memref<?xindex>, memref<?xf64>
 //   CHECK-DAG: %[[C0:.*]] = arith.constant 0 : index
 //   CHECK-DAG: %[[C1:.*]] = arith.constant 1 : index
+// CH__ECK-DAG: %[[F0:.*]] = arith.constant 0.000000e+00 : f64
 //       CHECK: %[[T0:.*]] = memref.alloc() : memref<1xindex>
 //       CHECK: %[[T1:.*]] = memref.alloc() : memref<3xindex>
 //       CHECK: %[[T2:.*]] = memref.alloc() : memref<16xindex>
@@ -17,6 +20,7 @@
 //       CHECK: linalg.fill ins(%[[C0]] : index) outs(%[[T4]] : memref<16xindex>)
 //       CHECK: %[[T6:.*]] = memref.alloc() : memref<16xf64>
 //       CHECK: %[[T7:.*]] = memref.cast %[[T6]] : memref<16xf64> to memref<?xf64>
+//     CH__ECK: linalg.fill ins(%[[F0]] : f64) outs(%[[T6]] : memref<16xf64>)
 //       CHECK: linalg.fill ins(%[[C0]] : index) outs(%[[T1]] : memref<3xindex>)
 //       CHECK: memref.store %[[A]], %[[T0]][%[[C0]]] : memref<1xindex>
 //       CHECK: %[[P0:.*]] = sparse_tensor.push_back %[[T1]], %[[T3]]