[Mlir-commits] [mlir] d1da6f2 - [mlir][sparse] avoid single default parameters in pass constructors

[Aart Bik]

Author: Aart Bik
Date: 2022-11-15T13:07:54-08:00
New Revision: d1da6f23a65beaf7b54f20b80c9415d2bf4ad956

URL: https://github.com/llvm/llvm-project/commit/d1da6f23a65beaf7b54f20b80c9415d2bf4ad956
DIFF: https://github.com/llvm/llvm-project/commit/d1da6f23a65beaf7b54f20b80c9415d2bf4ad956.diff

LOG: [mlir][sparse] avoid single default parameters in pass constructors

Reviewed By: bixia

Differential Revision: https://reviews.llvm.org/D138054

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.h
    mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.h b/mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.h
index 19ff2eb5cd916..badc3d0dfd876 100644
--- a/mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.h
+++ b/mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.h
@@ -133,8 +133,9 @@ void populateSparseTensorCodegenPatterns(TypeConverter &typeConverter,
                                          RewritePatternSet &patterns,
                                          bool enableBufferInitialization);
 
+std::unique_ptr<Pass> createSparseTensorCodegenPass();
 std::unique_ptr<Pass>
-createSparseTensorCodegenPass(bool enableBufferInitialization = false);
+createSparseTensorCodegenPass(bool enableBufferInitialization);
 
 //===----------------------------------------------------------------------===//
 // The SparseTensorRewriting pass.
@@ -157,8 +158,10 @@ std::unique_ptr<Pass> createDenseBufferizationPass(
 
 void populateSparseBufferRewriting(RewritePatternSet &patterns,
                                    bool enableBufferInitialization);
+
+std::unique_ptr<Pass> createSparseBufferRewritePass();
 std::unique_ptr<Pass>
-createSparseBufferRewritePass(bool enableBufferInitialization = false);
+createSparseBufferRewritePass(bool enableBufferInitialization);
 
 //===----------------------------------------------------------------------===//
 // Registration.

diff  --git a/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp b/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp
index c153dcd3d7057..da7c6ffda2080 100644
--- a/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp
+++ b/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp
@@ -283,11 +283,19 @@ std::unique_ptr<Pass> mlir::createSparseTensorConversionPass(
   return std::make_unique<SparseTensorConversionPass>(options);
 }
 
+std::unique_ptr<Pass> mlir::createSparseTensorCodegenPass() {
+  return std::make_unique<SparseTensorCodegenPass>();
+}
+
 std::unique_ptr<Pass>
 mlir::createSparseTensorCodegenPass(bool enableBufferInitialization) {
   return std::make_unique<SparseTensorCodegenPass>(enableBufferInitialization);
 }
 
+std::unique_ptr<Pass> mlir::createSparseBufferRewritePass() {
+  return std::make_unique<SparseBufferRewritePass>();
+}
+
 std::unique_ptr<Pass>
 mlir::createSparseBufferRewritePass(bool enableBufferInitialization) {
   return std::make_unique<SparseBufferRewritePass>(enableBufferInitialization);