[Mlir-commits] [mlir] cd5ee32 - [mlir] Fix warnings

[Kazu Hirata]

Author: Kazu Hirata
Date: 2022-11-15T12:16:03-08:00
New Revision: cd5ee321e5ed0081063bbe401288e9e09cb27552

URL: https://github.com/llvm/llvm-project/commit/cd5ee321e5ed0081063bbe401288e9e09cb27552
DIFF: https://github.com/llvm/llvm-project/commit/cd5ee321e5ed0081063bbe401288e9e09cb27552.diff

LOG: [mlir] Fix warnings

This patch fixes:

  mlir/lib/ExecutionEngine/SparseTensorRuntime.cpp:296:31: error:
  comparison of integers of different signs: 'int64_t' (aka 'long')
  and 'const uint64_t' (aka 'const unsigned long')
  [-Werror,-Wsign-compare]

  mlir/lib/ExecutionEngine/SparseTensorRuntime.cpp:297:67: error:
  comparison of integers of different signs: 'int64_t' (aka 'long')
  and 'const uint64_t' (aka 'const unsigned long')
  [-Werror,-Wsign-compare]

  mlir/lib/ExecutionEngine/SparseTensorRuntime.cpp:298:31: error:
 comparison of integers of different signs: 'int64_t' (aka 'long') and
 'const uint64_t' (aka 'const unsigned long') [-Werror,-Wsign-compare]

  mlir/lib/ExecutionEngine/SparseTensorRuntime.cpp:479:30: error:
  comparison of integers of different signs: 'int64_t' (aka 'long')
  and 'const uint64_t' (aka 'const unsigned long')
  [-Werror,-Wsign-compare]

Added: 
    

Modified: 
    mlir/lib/ExecutionEngine/SparseTensorRuntime.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/ExecutionEngine/SparseTensorRuntime.cpp b/mlir/lib/ExecutionEngine/SparseTensorRuntime.cpp
index d23a3ca5ab338..837b404f63a29 100644
--- a/mlir/lib/ExecutionEngine/SparseTensorRuntime.cpp
+++ b/mlir/lib/ExecutionEngine/SparseTensorRuntime.cpp
@@ -293,8 +293,9 @@ void *_mlir_ciface_newSparseTensor( // NOLINT
   assert(dim2lvlRef && dim2lvlRef->strides[0] == 1);
   const uint64_t dimRank = dimSizesRef->sizes[0];
   const uint64_t lvlRank = lvlSizesRef->sizes[0];
-  assert(dim2lvlRef->sizes[0] == dimRank);
-  assert(lvlTypesRef->sizes[0] == lvlRank && lvl2dimRef->sizes[0] == lvlRank);
+  assert(dim2lvlRef->sizes[0] == (int64_t)dimRank);
+  assert(lvlTypesRef->sizes[0] == (int64_t)lvlRank &&
+         lvl2dimRef->sizes[0] == (int64_t)lvlRank);
   const index_type *dimSizes = dimSizesRef->data + dimSizesRef->offset;
   const index_type *lvlSizes = lvlSizesRef->data + lvlSizesRef->offset;
   const DimLevelType *lvlTypes = lvlTypesRef->data + lvlTypesRef->offset;
@@ -465,7 +466,7 @@ MLIR_SPARSETENSOR_FOREVERY_O(IMPL_SPARSEINDICES)
     assert(lvlCOO &&vref &&dimIndRef &&dim2lvlRef);                            \
     assert(dimIndRef->strides[0] == 1 && dim2lvlRef->strides[0] == 1);         \
     const uint64_t rank = dimIndRef->sizes[0];                                 \
-    assert(dim2lvlRef->sizes[0] == rank);                                      \
+    assert(dim2lvlRef->sizes[0] == (int64_t)rank);                             \
     const index_type *dimInd = dimIndRef->data + dimIndRef->offset;            \
     const index_type *dim2lvl = dim2lvlRef->data + dim2lvlRef->offset;         \
     std::vector<index_type> lvlInd(rank);                                      \