[Mlir-commits] [mlir] 3bed21b - Apply clang-tidy fixes for readability-simplify-boolean-expr in GPUDialect.cpp (NFC)

Mehdi Amini llvmlistbot at llvm.org
Mon Nov 14 12:05:02 PST 2022


Author: Mehdi Amini
Date: 2022-11-14T20:04:16Z
New Revision: 3bed21bdd23cc41a98a37cc135b847977870a85c

URL: https://github.com/llvm/llvm-project/commit/3bed21bdd23cc41a98a37cc135b847977870a85c
DIFF: https://github.com/llvm/llvm-project/commit/3bed21bdd23cc41a98a37cc135b847977870a85c.diff

LOG: Apply clang-tidy fixes for readability-simplify-boolean-expr in GPUDialect.cpp (NFC)

Added: 
    

Modified: 
    mlir/lib/Dialect/GPU/IR/GPUDialect.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/GPU/IR/GPUDialect.cpp b/mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
index 2c30425f72458..0f25e51480737 100644
--- a/mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
+++ b/mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
@@ -311,10 +311,10 @@ static void printAsyncDependencies(OpAsmPrinter &printer, Operation *op,
 
 static bool verifyReduceOpAndType(gpu::AllReduceOperation opName,
                                   Type resType) {
-  return !((opName == gpu::AllReduceOperation::AND ||
-            opName == gpu::AllReduceOperation::OR ||
-            opName == gpu::AllReduceOperation::XOR) &&
-           !resType.isa<IntegerType>());
+  return (opName != gpu::AllReduceOperation::AND &&
+          opName != gpu::AllReduceOperation::OR &&
+          opName != gpu::AllReduceOperation::XOR) ||
+         resType.isa<IntegerType>();
 }
 
 LogicalResult gpu::AllReduceOp::verifyRegions() {


        


More information about the Mlir-commits mailing list