Author: Adrian Kuegel
Date: 2022-11-07T09:24:32+01:00
New Revision: abe2738b7b02f93941b9e193e637e99d4e3c1581
URL: https://github.com/llvm/llvm-project/commit/abe2738b7b02f93941b9e193e637e99d4e3c1581
DIFF: https://github.com/llvm/llvm-project/commit/abe2738b7b02f93941b9e193e637e99d4e3c1581.diff
LOG: [mlir] Apply two ClangTidy findings.
- argument name 'isLastOutput' in comment does not match parameter name
'hasOutput'.
- override is redundant since the function is already declared 'final'.
Added:
Modified:
mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
mlir/lib/Dialect/Vector/Transforms/LowerVectorMask.cpp
Removed:
################################################################################
diff --git a/mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp b/mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
index 11e9a649984cf..533d31fdb5536 100644
--- a/mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
+++ b/mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
@@ -56,7 +56,7 @@ struct CodeGen {
CodeGen(SparsificationOptions o, ValueRange tensors, unsigned numTensors,
unsigned numLoops, OpOperand *op, unsigned nest,
std::vector<unsigned> &ts)
- : options(o), loopEmitter(tensors, /*isLastOutput=*/true,
+ : options(o), loopEmitter(tensors, /*hasOutput=*/true,
/*isSparseOut=*/op != nullptr),
sparseOut(op), outerParNest(nest), topSort(ts) {
if (op)
diff --git a/mlir/lib/Dialect/Vector/Transforms/LowerVectorMask.cpp b/mlir/lib/Dialect/Vector/Transforms/LowerVectorMask.cpp
index ca285465648ff..aa79e54b9b306 100644
--- a/mlir/lib/Dialect/Vector/Transforms/LowerVectorMask.cpp
+++ b/mlir/lib/Dialect/Vector/Transforms/LowerVectorMask.cpp
@@ -46,9 +46,8 @@ struct MaskOpRewritePattern : OpRewritePattern<MaskOp> {
using OpRewritePattern<MaskOp>::OpRewritePattern;
private:
- LogicalResult
- matchAndRewrite(MaskOp maskOp,
- PatternRewriter &rewriter) const override final {
+ LogicalResult matchAndRewrite(MaskOp maskOp,
+ PatternRewriter &rewriter) const final {
MaskableOpInterface maskableOp = maskOp.getMaskableOp();
SourceOp sourceOp = dyn_cast<SourceOp>(maskableOp.getOperation());
if (!sourceOp)