[Mlir-commits] [mlir] c310a6d - Apply clang-tidy fixes for readability-simplify-boolean-expr in GPUDialect.cpp (NFC)

Mehdi Amini llvmlistbot at llvm.org
Sun Nov 6 12:19:29 PST 2022


Author: Mehdi Amini
Date: 2022-11-06T20:15:00Z
New Revision: c310a6dda2f2f2a7011eb817431a0bb6774717c9

URL: https://github.com/llvm/llvm-project/commit/c310a6dda2f2f2a7011eb817431a0bb6774717c9
DIFF: https://github.com/llvm/llvm-project/commit/c310a6dda2f2f2a7011eb817431a0bb6774717c9.diff

LOG: Apply clang-tidy fixes for readability-simplify-boolean-expr in GPUDialect.cpp (NFC)

Added: 
    

Modified: 
    mlir/lib/Dialect/GPU/IR/GPUDialect.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/GPU/IR/GPUDialect.cpp b/mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
index 3eee6081e7eef..2c30425f72458 100644
--- a/mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
+++ b/mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
@@ -311,13 +311,10 @@ static void printAsyncDependencies(OpAsmPrinter &printer, Operation *op,
 
 static bool verifyReduceOpAndType(gpu::AllReduceOperation opName,
                                   Type resType) {
-  if ((opName == gpu::AllReduceOperation::AND ||
-       opName == gpu::AllReduceOperation::OR ||
-       opName == gpu::AllReduceOperation::XOR) &&
-      !resType.isa<IntegerType>())
-    return false;
-
-  return true;
+  return !((opName == gpu::AllReduceOperation::AND ||
+            opName == gpu::AllReduceOperation::OR ||
+            opName == gpu::AllReduceOperation::XOR) &&
+           !resType.isa<IntegerType>());
 }
 
 LogicalResult gpu::AllReduceOp::verifyRegions() {


        


More information about the Mlir-commits mailing list