[Mlir-commits] [mlir] 3b13f88 - [mlir][sparse] fix unsigned comparison bug in assert

[Aart Bik]

Author: Aart Bik
Date: 2022-05-19T13:32:09-07:00
New Revision: 3b13f8805c0225046558b7c6657860f39f4e78f9

URL: https://github.com/llvm/llvm-project/commit/3b13f8805c0225046558b7c6657860f39f4e78f9
DIFF: https://github.com/llvm/llvm-project/commit/3b13f8805c0225046558b7c6657860f39f4e78f9.diff

LOG: [mlir][sparse] fix unsigned comparison bug in assert

Reviewed By: bixia, wrengr

Differential Revision: https://reviews.llvm.org/D126007

Added: 
    

Modified: 
    mlir/lib/ExecutionEngine/SparseTensorUtils.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/ExecutionEngine/SparseTensorUtils.cpp b/mlir/lib/ExecutionEngine/SparseTensorUtils.cpp
index 24d77a6c3ec3f..21ad81525a1e1 100644
--- a/mlir/lib/ExecutionEngine/SparseTensorUtils.cpp
+++ b/mlir/lib/ExecutionEngine/SparseTensorUtils.cpp
@@ -885,7 +885,7 @@ class SparseTensorEnumerator final : public SparseTensorEnumeratorBase<V> {
       const uint64_t pstop = static_cast<uint64_t>(pointers_d[parentPos + 1]);
       // Loop-invariant code for looking up the `d`-level coordinates/indices.
       const std::vector<I> &indices_d = src.indices[d];
-      assert(pstop - 1 < indices_d.size() && "Index position is out of bounds");
+      assert(pstop <= indices_d.size() && "Index position is out of bounds");
       uint64_t &cursor_reord_d = this->cursor[this->reord[d]];
       for (uint64_t pos = pstart; pos < pstop; pos++) {
         cursor_reord_d = static_cast<uint64_t>(indices_d[pos]);