[Mlir-commits] [mlir] 70c463e - [mlir][NFC] Fix `GpuKernelOutliningPass` copy constructor warnings

Daniil Dudkin llvmlistbot at llvm.org
Thu May 12 01:41:56 PDT 2022


Author: Daniil Dudkin
Date: 2022-05-12T11:41:18+03:00
New Revision: 70c463efc8dfb423e31a98c08e01da0079e795dc

URL: https://github.com/llvm/llvm-project/commit/70c463efc8dfb423e31a98c08e01da0079e795dc
DIFF: https://github.com/llvm/llvm-project/commit/70c463efc8dfb423e31a98c08e01da0079e795dc.diff

LOG: [mlir][NFC] Fix `GpuKernelOutliningPass` copy constructor warnings

1. Call copy constructor of the base class
2. Assign value of the option directly

Reviewed By: dcaballe, rriddle

Differential Revision: https://reviews.llvm.org/D125101

Added: 
    

Modified: 
    mlir/lib/Dialect/GPU/Transforms/KernelOutlining.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/GPU/Transforms/KernelOutlining.cpp b/mlir/lib/Dialect/GPU/Transforms/KernelOutlining.cpp
index 3019cc8bcfa49..12897d66678e6 100644
--- a/mlir/lib/Dialect/GPU/Transforms/KernelOutlining.cpp
+++ b/mlir/lib/Dialect/GPU/Transforms/KernelOutlining.cpp
@@ -274,8 +274,8 @@ class GpuKernelOutliningPass
   }
 
   GpuKernelOutliningPass(const GpuKernelOutliningPass &other)
-      : dataLayoutSpec(other.dataLayoutSpec) {
-    dataLayoutStr = other.dataLayoutStr;
+      : GpuKernelOutliningBase(other), dataLayoutSpec(other.dataLayoutSpec) {
+    dataLayoutStr = other.dataLayoutStr.getValue();
   }
 
   LogicalResult initialize(MLIRContext *context) override {


        


More information about the Mlir-commits mailing list