[Mlir-commits] [mlir] 3807583 - [mlir:PDLL][NFC] Remove a dead comment about constant params

[River Riddle]

Author: River Riddle
Date: 2022-03-19T13:38:27-07:00
New Revision: 3807583b8f879e4ecfc63b268622aee399fbe05a

URL: https://github.com/llvm/llvm-project/commit/3807583b8f879e4ecfc63b268622aee399fbe05a
DIFF: https://github.com/llvm/llvm-project/commit/3807583b8f879e4ecfc63b268622aee399fbe05a.diff

LOG: [mlir:PDLL][NFC] Remove a dead comment about constant params

These were removed, and the FIXME is no longer relevant.

Added: 
    

Modified: 
    mlir/lib/Tools/PDLL/CodeGen/CPPGen.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Tools/PDLL/CodeGen/CPPGen.cpp b/mlir/lib/Tools/PDLL/CodeGen/CPPGen.cpp
index 14cdf44628a77..c6937aa736a11 100644
--- a/mlir/lib/Tools/PDLL/CodeGen/CPPGen.cpp
+++ b/mlir/lib/Tools/PDLL/CodeGen/CPPGen.cpp
@@ -183,11 +183,6 @@ void CodeGen::generateConstraintOrRewrite(StringRef name, bool isConstraint,
         .Case([&](ast::TypeRangeType) { return "::mlir::TypeRange"; })
         .Case([&](ast::ValueRangeType) { return "::mlir::ValueRange"; });
   };
-
-  // FIXME: We currently do not have a modeling for the "constant params"
-  // support PDL provides. We should either figure out a modeling for this, or
-  // refactor the support within PDL to be something a bit more reasonable for
-  // what we need as a frontend.
   os << "static " << (isConstraint ? "::mlir::LogicalResult " : "void ") << name
      << "PDLFn(::llvm::ArrayRef<::mlir::PDLValue> values, "
         "::mlir::PatternRewriter &rewriter"