[Mlir-commits] [mlir] 4e817b3 - [MLIR][AMDGPU] Fix typo and add comment to SerializeToHsaco

Krzysztof Drewniak llvmlistbot at llvm.org
Fri Mar 4 09:15:16 PST 2022


Author: Krzysztof Drewniak
Date: 2022-03-04T17:15:11Z
New Revision: 4e817b3fa36b0c8664a49af5c598f96efe8cfc18

URL: https://github.com/llvm/llvm-project/commit/4e817b3fa36b0c8664a49af5c598f96efe8cfc18
DIFF: https://github.com/llvm/llvm-project/commit/4e817b3fa36b0c8664a49af5c598f96efe8cfc18.diff

LOG: [MLIR][AMDGPU] Fix typo and add comment to SerializeToHsaco

Reviewed By: bondhugula

Differential Revision: https://reviews.llvm.org/D120943

Added: 
    

Modified: 
    mlir/lib/Dialect/GPU/Transforms/SerializeToHsaco.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/GPU/Transforms/SerializeToHsaco.cpp b/mlir/lib/Dialect/GPU/Transforms/SerializeToHsaco.cpp
index 36285ed0671b8..d33aa9dc931c0 100644
--- a/mlir/lib/Dialect/GPU/Transforms/SerializeToHsaco.cpp
+++ b/mlir/lib/Dialect/GPU/Transforms/SerializeToHsaco.cpp
@@ -239,6 +239,7 @@ SerializeToHsacoPass::translateToLLVMIR(llvm::LLVMContext &llvmContext) {
     constant->setAlignment(llvm::MaybeAlign(bitwidth / 8));
   };
 
+  // Set up control variables in the module instead of linking in tiny bitcode
   if (needOcml) {
     // TODO(kdrewnia): Enable math optimizations once we have support for
     // `-ffast-math`-like options
@@ -277,7 +278,7 @@ SerializeToHsacoPass::translateToLLVMIR(llvm::LLVMContext &llvmContext) {
 
   if (!mbModules) {
     getOperation()
-            .emitWarning("Could not load required device labraries")
+            .emitWarning("Could not load required device libraries")
             .attachNote()
         << "This will probably cause link-time or run-time failures";
     return ret; // We can still abort here


        


More information about the Mlir-commits mailing list