[Mlir-commits] [mlir] da0f151 - [MLIR][Affine][NFC] Fix affine utlities docs using "identifiers" instead of "variables"

[llvmlistbot at llvm.org]

Author: Groverkss
Date: 2022-06-28T19:35:17+01:00
New Revision: da0f15140187cbabac4386f4840132ad66a6fecc

URL: https://github.com/llvm/llvm-project/commit/da0f15140187cbabac4386f4840132ad66a6fecc
DIFF: https://github.com/llvm/llvm-project/commit/da0f15140187cbabac4386f4840132ad66a6fecc.diff

LOG: [MLIR][Affine][NFC] Fix affine utlities docs using "identifiers" instead of "variables"

Added: 
    

Modified: 
    mlir/lib/Dialect/Affine/Analysis/AffineAnalysis.cpp
    mlir/lib/Dialect/Affine/Utils/LoopUtils.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/Affine/Analysis/AffineAnalysis.cpp b/mlir/lib/Dialect/Affine/Analysis/AffineAnalysis.cpp
index b1d662bf08e5..4e8952da9de6 100644
--- a/mlir/lib/Dialect/Affine/Analysis/AffineAnalysis.cpp
+++ b/mlir/lib/Dialect/Affine/Analysis/AffineAnalysis.cpp
@@ -233,7 +233,7 @@ void mlir::getReachableAffineApplyOps(
   }
 }
 
-// Builds a system of constraints with dimensional identifiers corresponding to
+// Builds a system of constraints with dimensional variables corresponding to
 // the loop IVs of the forOps appearing in that order. Any symbols founds in
 // the bound operands are added as symbols in the system. Returns failure for
 // the yet unimplemented cases.
@@ -269,7 +269,7 @@ LogicalResult mlir::getIndexSet(MutableArrayRef<Operation *> ops,
 
 /// Computes the iteration domain for 'op' and populates 'indexSet', which
 /// encapsulates the constraints involving loops surrounding 'op' and
-/// potentially involving any Function symbols. The dimensional identifiers in
+/// potentially involving any Function symbols. The dimensional variables in
 /// 'indexSet' correspond to the loops surrounding 'op' from outermost to
 /// innermost.
 static LogicalResult getOpIndexSet(Operation *op,
@@ -533,7 +533,7 @@ void MemRefAccess::getAccessMap(AffineValueMap *accessMap) const {
 //
 // This method builds a constraint system with the following column format:
 //
-//  [src-dim-identifiers, dst-dim-identifiers, symbols, constant]
+//  [src-dim-variables, dst-dim-variables, symbols, constant]
 //
 // For example, given the following MLIR code with "source" and "destination"
 // accesses to the same memref label, and symbols %M, %N, %K:

diff  --git a/mlir/lib/Dialect/Affine/Utils/LoopUtils.cpp b/mlir/lib/Dialect/Affine/Utils/LoopUtils.cpp
index cee961657980..2d0ec634b14c 100644
--- a/mlir/lib/Dialect/Affine/Utils/LoopUtils.cpp
+++ b/mlir/lib/Dialect/Affine/Utils/LoopUtils.cpp
@@ -2756,7 +2756,7 @@ createFullTiles(MutableArrayRef<AffineForOp> inputNest,
       return failure();
     }
 
-    // Set all identifiers as dimensions uniformly since some of those marked as
+    // Set all variables as dimensions uniformly since some of those marked as
     // symbols above could be outer loop IVs (corresponding tile space IVs).
     cst.setDimSymbolSeparation(/*newSymbolCount=*/0);