[Mlir-commits] [mlir] 743791d - [mlir] Include attributes in ML program dialect ops def

[Jacques Pienaar]

Author: Jacques Pienaar
Date: 2022-06-13T21:35:34-07:00
New Revision: 743791d6d5a4a34bcf45d0e33f08928b10160e6b

URL: https://github.com/llvm/llvm-project/commit/743791d6d5a4a34bcf45d0e33f08928b10160e6b
DIFF: https://github.com/llvm/llvm-project/commit/743791d6d5a4a34bcf45d0e33f08928b10160e6b.diff

LOG: [mlir] Include attributes in ML program dialect ops def

I considered adding a new dialect top-level file with all ops,
attributes & types included, but didn't see practical benefit to it.

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/MLProgram/IR/CMakeLists.txt
    mlir/include/mlir/Dialect/MLProgram/IR/MLProgramOps.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/MLProgram/IR/CMakeLists.txt b/mlir/include/mlir/Dialect/MLProgram/IR/CMakeLists.txt
index 51187d7a1480..6e8947197a89 100644
--- a/mlir/include/mlir/Dialect/MLProgram/IR/CMakeLists.txt
+++ b/mlir/include/mlir/Dialect/MLProgram/IR/CMakeLists.txt
@@ -7,7 +7,6 @@ mlir_tablegen(MLProgramAttributes.h.inc -gen-attrdef-decls)
 mlir_tablegen(MLProgramAttributes.cpp.inc -gen-attrdef-defs)
 add_public_tablegen_target(MLIRMLProgramAttributesIncGen)
 add_dependencies(mlir-headers MLIRMLProgramAttributesIncGen)
-add_mlir_doc(MLProgramAttributes MLProgramAttributes Dialects/ -gen-attrdef-doc)
 
 set(LLVM_TARGET_DEFINITIONS MLProgramTypes.td)
 mlir_tablegen(MLProgramTypes.h.inc -gen-typedef-decls)

diff  --git a/mlir/include/mlir/Dialect/MLProgram/IR/MLProgramOps.td b/mlir/include/mlir/Dialect/MLProgram/IR/MLProgramOps.td
index f4dc56fee4da..d820573b200a 100644
--- a/mlir/include/mlir/Dialect/MLProgram/IR/MLProgramOps.td
+++ b/mlir/include/mlir/Dialect/MLProgram/IR/MLProgramOps.td
@@ -10,6 +10,7 @@
 #define MLPROGRAM_OPS
 
 include "mlir/Dialect/MLProgram/IR/MLProgramBase.td"
+include "mlir/Dialect/MLProgram/IR/MLProgramAttributes.td"
 include "mlir/Dialect/MLProgram/IR/MLProgramTypes.td"
 include "mlir/Interfaces/CallInterfaces.td"
 include "mlir/Interfaces/ControlFlowInterfaces.td"