[Mlir-commits] [mlir] a10c09d - [mlir][spirv] Remove unused `traits` from `SPV_Attr`

[Lei Zhang]

Author: Lei Zhang
Date: 2022-06-13T12:20:57-04:00
New Revision: a10c09d1e38bac0eb2db32ecbc083ea8d86fd6a0

URL: https://github.com/llvm/llvm-project/commit/a10c09d1e38bac0eb2db32ecbc083ea8d86fd6a0
DIFF: https://github.com/llvm/llvm-project/commit/a10c09d1e38bac0eb2db32ecbc083ea8d86fd6a0.diff

LOG: [mlir][spirv] Remove unused `traits` from `SPV_Attr`

This addresses the warning of unused template argument.

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/SPIRV/IR/SPIRVAttributes.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVAttributes.td b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVAttributes.td
index 401c11f3bdb5f..791615274d52f 100644
--- a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVAttributes.td
+++ b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVAttributes.td
@@ -23,7 +23,7 @@
 
 include "mlir/Dialect/SPIRV/IR/SPIRVBase.td"
 
-class SPV_Attr<string attrName, string attrMnemonic, list<Trait> traits = []>
+class SPV_Attr<string attrName, string attrMnemonic>
     : AttrDef<SPIRV_Dialect, attrName> {
   let mnemonic = attrMnemonic;
 }
@@ -48,14 +48,14 @@ def SPV_CapabilityArrayAttr : TypedArrayAttrBase<
 def SPV_CooperativeMatrixPropertiesNVAttr :
     SPV_Attr<"CooperativeMatrixPropertiesNV", "coop_matrix_props"> {
   let parameters = (ins
-    "int":$m_size, 
-    "int":$n_size, 
-    "int":$k_size, 
-    "mlir::Type":$a_type, 
-    "mlir::Type":$b_type, 
-    "mlir::Type":$c_type, 
-    "mlir::Type":$result_type, 
-    "mlir::spirv::ScopeAttr":$scope 
+    "int":$m_size,
+    "int":$n_size,
+    "int":$k_size,
+    "mlir::Type":$a_type,
+    "mlir::Type":$b_type,
+    "mlir::Type":$c_type,
+    "mlir::Type":$result_type,
+    "mlir::spirv::ScopeAttr":$scope
   );
   let assemblyFormat = "`<` struct(params) `>`";
 }
@@ -93,7 +93,7 @@ def SPV_ResourceLimitsAttr : SPV_Attr<"ResourceLimits", "resource_limits"> {
     // The configurations of cooperative matrix operations
     // supported. Default is an empty list.
     DefaultValuedParameter<
-      "ArrayAttr", 
+      "ArrayAttr",
       "nullptr"
     >:$cooperative_matrix_properties_nv
   );