[Mlir-commits] [mlir] 9bbc0d4 - [mlir:LSP] Drop potentialy annoying completion commit characters

River Riddle llvmlistbot at llvm.org
Fri Jul 8 17:57:07 PDT 2022


Author: River Riddle
Date: 2022-07-08T17:56:48-07:00
New Revision: 9bbc0d4eb1c1a0436fe1142c59005ee611c9b15a

URL: https://github.com/llvm/llvm-project/commit/9bbc0d4eb1c1a0436fe1142c59005ee611c9b15a
DIFF: https://github.com/llvm/llvm-project/commit/9bbc0d4eb1c1a0436fe1142c59005ee611c9b15a.diff

LOG: [mlir:LSP] Drop potentialy annoying completion commit characters

These can result in accidentally accepting a completion when it isn't intended.

Added: 
    

Modified: 
    mlir/lib/Tools/mlir-lsp-server/LSPServer.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Tools/mlir-lsp-server/LSPServer.cpp b/mlir/lib/Tools/mlir-lsp-server/LSPServer.cpp
index a3b86af4249d..837514c50311 100644
--- a/mlir/lib/Tools/mlir-lsp-server/LSPServer.cpp
+++ b/mlir/lib/Tools/mlir-lsp-server/LSPServer.cpp
@@ -100,8 +100,7 @@ void LSPServer::Impl::onInitialize(const InitializeParams &params,
       {"completionProvider",
        llvm::json::Object{
            {"allCommitCharacters",
-            {"\t", "(", ")", "[", "]", "<", ">", ";", ",", "+", "-", "/", "*",
-             "&", "?", ".", "=", "|"}},
+            {"\t", ";", ",", "+", "-", "/", "*", "&", "?", ".", "=", "|"}},
            {"resolveProvider", false},
            {"triggerCharacters",
             {".", "%", "^", "!", "#", "(", ",", "<", ":", "[", " ", "\"", "/"}},


        


More information about the Mlir-commits mailing list