[Mlir-commits] [mlir] 18e33ba - Remove `mutable` and stray comment

Sanjoy Das llvmlistbot at llvm.org
Mon Jan 31 12:44:17 PST 2022


Author: Sanjoy Das
Date: 2022-01-31T12:33:20-08:00
New Revision: 18e33ba9c94e7888450349025f6b6bff9f82ed5f

URL: https://github.com/llvm/llvm-project/commit/18e33ba9c94e7888450349025f6b6bff9f82ed5f
DIFF: https://github.com/llvm/llvm-project/commit/18e33ba9c94e7888450349025f6b6bff9f82ed5f.diff

LOG: Remove `mutable` and stray comment

The `mutable` was added back when `scope` was a `DataLayoutOpInterface`.

Differential Revision: https://reviews.llvm.org/D118643

Added: 
    

Modified: 
    mlir/include/mlir/Interfaces/DataLayoutInterfaces.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Interfaces/DataLayoutInterfaces.h b/mlir/include/mlir/Interfaces/DataLayoutInterfaces.h
index 6d214ed30236..5cc80a06f363 100644
--- a/mlir/include/mlir/Interfaces/DataLayoutInterfaces.h
+++ b/mlir/include/mlir/Interfaces/DataLayoutInterfaces.h
@@ -173,9 +173,7 @@ class DataLayout {
   void checkValid() const;
 
   /// Operation defining the scope of requests.
-  // TODO: this is mutable because the generated interface method are not const.
-  // Update the generator to support const methods and change this to const.
-  mutable Operation *scope;
+  Operation *scope;
 
   /// Caches for individual requests.
   mutable DenseMap<Type, unsigned> sizes;


        


More information about the Mlir-commits mailing list