[Mlir-commits] [mlir] d03c5bc - [mlir] Fully qualify return types in OpAsmInterface.td and FunctionInterfaces.td

[Markus Böck]

Author: Markus Böck
Date: 2022-01-21T10:04:02+01:00
New Revision: d03c5bc8d437e47ae424ac9611ae441cd5225526

URL: https://github.com/llvm/llvm-project/commit/d03c5bc8d437e47ae424ac9611ae441cd5225526
DIFF: https://github.com/llvm/llvm-project/commit/d03c5bc8d437e47ae424ac9611ae441cd5225526.diff

LOG: [mlir] Fully qualify return types in OpAsmInterface.td and FunctionInterfaces.td

Added: 
    

Modified: 
    mlir/include/mlir/IR/FunctionInterfaces.td
    mlir/include/mlir/IR/OpAsmInterface.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/IR/FunctionInterfaces.td b/mlir/include/mlir/IR/FunctionInterfaces.td
index b6993ff6ffc76..20c7d7bbd51b7 100644
--- a/mlir/include/mlir/IR/FunctionInterfaces.td
+++ b/mlir/include/mlir/IR/FunctionInterfaces.td
@@ -55,13 +55,13 @@ def FunctionOpInterface : OpInterface<"FunctionOpInterface"> {
       the type (to allow for this method may be called on function
       declarations).
     }],
-    "ArrayRef<Type>", "getArgumentTypes">,
+    "::llvm::ArrayRef<::mlir::Type>", "getArgumentTypes">,
     InterfaceMethod<[{
       Returns the function result types based exclusively on
       the type (to allow for this method may be called on function
       declarations).
     }],
-    "ArrayRef<Type>", "getResultTypes">,
+    "::llvm::ArrayRef<::mlir::Type>", "getResultTypes">,
     InterfaceMethod<[{
       Returns a clone of the function type with the given argument and
       result types.
@@ -70,7 +70,7 @@ def FunctionOpInterface : OpInterface<"FunctionOpInterface"> {
             an appropriate clone method:
               `Type clone(ArrayRef<Type> inputs, ArrayRef<Type> results)`
     }],
-    "Type", "cloneTypeWith", (ins
+    "::mlir::Type", "cloneTypeWith", (ins
       "::mlir::TypeRange":$inputs, "::mlir::TypeRange":$results
     ), /*methodBody=*/[{}], /*defaultImplementation=*/[{
       return $_op.getType().clone(inputs, results);

diff  --git a/mlir/include/mlir/IR/OpAsmInterface.td b/mlir/include/mlir/IR/OpAsmInterface.td
index b49e12ea9a85e..c13e59fb1b466 100644
--- a/mlir/include/mlir/IR/OpAsmInterface.td
+++ b/mlir/include/mlir/IR/OpAsmInterface.td
@@ -70,7 +70,7 @@ def OpAsmOpInterface : OpInterface<"OpAsmOpInterface"> {
       returned `spv`. The default implementation returns an empty string which
       is ignored.
       }],
-      "StringRef", "getDefaultDialect", (ins), "", "return \"\";"
+      "::llvm::StringRef", "getDefaultDialect", (ins), "", "return \"\";"
     >,
   ];
 }