[Mlir-commits] [mlir] bd87241 - Apply clang-tidy fixes for modernize-use-override to MLIR (NFC)

[Mehdi Amini]

Author: Mehdi Amini
Date: 2022-01-14T02:26:27Z
New Revision: bd87241c44b2fa2f24de653ab560e64362a87eaf

URL: https://github.com/llvm/llvm-project/commit/bd87241c44b2fa2f24de653ab560e64362a87eaf
DIFF: https://github.com/llvm/llvm-project/commit/bd87241c44b2fa2f24de653ab560e64362a87eaf.diff

LOG: Apply clang-tidy fixes for modernize-use-override to MLIR (NFC)

Added: 
    

Modified: 
    mlir/include/mlir/Analysis/AffineStructures.h
    mlir/include/mlir/Support/Timing.h
    mlir/lib/Bindings/Python/IRModule.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Analysis/AffineStructures.h b/mlir/include/mlir/Analysis/AffineStructures.h
index ed4ca4cea96a..1bcafe24ca2a 100644
--- a/mlir/include/mlir/Analysis/AffineStructures.h
+++ b/mlir/include/mlir/Analysis/AffineStructures.h
@@ -93,7 +93,7 @@ class FlatAffineConstraints : public IntegerPolyhedron {
 
   FlatAffineConstraints(const MutableAffineMap &map);
 
-  virtual ~FlatAffineConstraints() = default;
+  ~FlatAffineConstraints() override = default;
 
   /// Return the kind of this FlatAffineConstraints.
   Kind getKind() const override { return Kind::FlatAffineConstraints; }
@@ -358,8 +358,7 @@ class FlatAffineValueConstraints : public FlatAffineConstraints {
   using FlatAffineConstraints::insertDimId;
   unsigned insertSymbolId(unsigned pos, ValueRange vals);
   using FlatAffineConstraints::insertSymbolId;
-  virtual unsigned insertId(IdKind kind, unsigned pos,
-                            unsigned num = 1) override;
+  unsigned insertId(IdKind kind, unsigned pos, unsigned num = 1) override;
   unsigned insertId(IdKind kind, unsigned pos, ValueRange vals);
 
   /// Append identifiers of the specified kind after the last identifier of that
@@ -521,7 +520,7 @@ class FlatAffineValueConstraints : public FlatAffineConstraints {
   /// Removes identifiers in the column range [idStart, idLimit), and copies any
   /// remaining valid data into place, updates member variables, and resizes
   /// arrays as needed.
-  virtual void removeIdRange(unsigned idStart, unsigned idLimit) override;
+  void removeIdRange(unsigned idStart, unsigned idLimit) override;
 
   /// Eliminates the identifier at the specified position using Fourier-Motzkin
   /// variable elimination, but uses Gaussian elimination if there is an

diff  --git a/mlir/include/mlir/Support/Timing.h b/mlir/include/mlir/Support/Timing.h
index 0528499196c1..1fcd8293f342 100644
--- a/mlir/include/mlir/Support/Timing.h
+++ b/mlir/include/mlir/Support/Timing.h
@@ -353,7 +353,7 @@ class DefaultTimingManager : public TimingManager {
 
   DefaultTimingManager();
   DefaultTimingManager(DefaultTimingManager &&rhs);
-  virtual ~DefaultTimingManager();
+  ~DefaultTimingManager() override;
 
   // Disable copying of the `DefaultTimingManager`.
   DefaultTimingManager(const DefaultTimingManager &rhs) = delete;

diff  --git a/mlir/lib/Bindings/Python/IRModule.h b/mlir/lib/Bindings/Python/IRModule.h
index 698fc6dc70ff..4f1b65610786 100644
--- a/mlir/lib/Bindings/Python/IRModule.h
+++ b/mlir/lib/Bindings/Python/IRModule.h
@@ -496,7 +496,7 @@ class PyOperation;
 using PyOperationRef = PyObjectRef<PyOperation>;
 class PyOperation : public PyOperationBase, public BaseContextObject {
 public:
-  ~PyOperation();
+  ~PyOperation() override;
   PyOperation &getOperation() override { return *this; }
 
   /// Returns a PyOperation for the given MlirOperation, optionally associating