[Mlir-commits] [mlir] e56a9c9 - Remove redundant return statements (NFC)

Kazu Hirata llvmlistbot at llvm.org
Fri Jan 7 07:42:47 PST 2022


Author: Kazu Hirata
Date: 2022-01-07T07:42:35-08:00
New Revision: e56a9c9b5b83923b8ed7b21994e6f9f11166aae0

URL: https://github.com/llvm/llvm-project/commit/e56a9c9b5b83923b8ed7b21994e6f9f11166aae0
DIFF: https://github.com/llvm/llvm-project/commit/e56a9c9b5b83923b8ed7b21994e6f9f11166aae0.diff

LOG: Remove redundant return statements (NFC)

Identified by readability-redundant-control-flow.

Added: 
    

Modified: 
    clang-tools-extra/clangd/TUScheduler.cpp
    mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp
    mlir/lib/Dialect/Affine/Utils/Utils.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/TUScheduler.cpp b/clang-tools-extra/clangd/TUScheduler.cpp
index 33df549d238de..43b4d8ca8881f 100644
--- a/clang-tools-extra/clangd/TUScheduler.cpp
+++ b/clang-tools-extra/clangd/TUScheduler.cpp
@@ -856,7 +856,6 @@ void ASTWorker::update(ParseInputs Inputs, WantDiagnostics WantDiags,
       // LatestPreamble is only populated by ASTWorker thread.
       return LatestPreamble || !PreambleRequests.empty() || Done;
     });
-    return;
   };
   startTask(TaskName, std::move(Task), UpdateType{WantDiags, ContentChanged},
             TUScheduler::NoInvalidation);

diff  --git a/mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp b/mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp
index 036cc6b03f76e..fe15d447940c6 100644
--- a/mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp
+++ b/mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp
@@ -1324,7 +1324,6 @@ static Operation *vectorizeAffineForOp(AffineForOp forOp,
       /*bodyBuilder=*/[](OpBuilder &, Location, Value, ValueRange) {
         // Make sure we don't create a default terminator in the loop body as
         // the proper terminator will be added during vectorization.
-        return;
       });
 
   // Register loop-related replacements:

diff  --git a/mlir/lib/Dialect/Affine/Utils/Utils.cpp b/mlir/lib/Dialect/Affine/Utils/Utils.cpp
index 480c09aa97a1f..1037040333cb5 100644
--- a/mlir/lib/Dialect/Affine/Utils/Utils.cpp
+++ b/mlir/lib/Dialect/Affine/Utils/Utils.cpp
@@ -537,7 +537,6 @@ static bool hasNoInterveningEffect(Operation *start, T memOp) {
     // Otherwise, conservatively assume generic operations have the effect
     // on the operation
     hasSideEffect = true;
-    return;
   };
 
   // Check all paths from ancestor op `parent` to the operation `to` for the


        


More information about the Mlir-commits mailing list