[Mlir-commits] [mlir] 5caee21 - Apply clang-tidy fixes for bugprone-argument-comment to MLIR ArithmeticOps.cpp (NFC)

Mehdi Amini llvmlistbot at llvm.org
Sun Jan 2 14:18:13 PST 2022


Author: Mehdi Amini
Date: 2022-01-02T22:14:48Z
New Revision: 5caee2176ae79fb923de174bf229d9b75eb37add

URL: https://github.com/llvm/llvm-project/commit/5caee2176ae79fb923de174bf229d9b75eb37add
DIFF: https://github.com/llvm/llvm-project/commit/5caee2176ae79fb923de174bf229d9b75eb37add.diff

LOG: Apply clang-tidy fixes for bugprone-argument-comment to MLIR ArithmeticOps.cpp (NFC)

Added: 
    

Modified: 
    mlir/lib/Dialect/Arithmetic/IR/ArithmeticOps.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/Arithmetic/IR/ArithmeticOps.cpp b/mlir/lib/Dialect/Arithmetic/IR/ArithmeticOps.cpp
index 98f617082f21f..91cbf4bdb5280 100644
--- a/mlir/lib/Dialect/Arithmetic/IR/ArithmeticOps.cpp
+++ b/mlir/lib/Dialect/Arithmetic/IR/ArithmeticOps.cpp
@@ -905,7 +905,7 @@ OpFoldResult arith::UIToFPOp::fold(ArrayRef<Attribute> operands) {
     FloatType floatTy = getType().cast<FloatType>();
     APFloat apf(floatTy.getFloatSemantics(),
                 APInt::getZero(floatTy.getWidth()));
-    apf.convertFromAPInt(api, /*signed=*/false, APFloat::rmNearestTiesToEven);
+    apf.convertFromAPInt(api, /*IsSigned=*/false, APFloat::rmNearestTiesToEven);
     return FloatAttr::get(floatTy, apf);
   }
   return {};
@@ -925,7 +925,7 @@ OpFoldResult arith::SIToFPOp::fold(ArrayRef<Attribute> operands) {
     FloatType floatTy = getType().cast<FloatType>();
     APFloat apf(floatTy.getFloatSemantics(),
                 APInt::getZero(floatTy.getWidth()));
-    apf.convertFromAPInt(api, /*signed=*/true, APFloat::rmNearestTiesToEven);
+    apf.convertFromAPInt(api, /*IsSigned=*/true, APFloat::rmNearestTiesToEven);
     return FloatAttr::get(floatTy, apf);
   }
   return {};
@@ -943,7 +943,7 @@ OpFoldResult arith::FPToUIOp::fold(ArrayRef<Attribute> operands) {
     const APFloat &apf = lhs.getValue();
     IntegerType intTy = getType().cast<IntegerType>();
     bool ignored;
-    APSInt api(intTy.getWidth(), /*unsigned=*/true);
+    APSInt api(intTy.getWidth(), /*isUnsigned=*/true);
     if (APFloat::opInvalidOp ==
         apf.convertToInteger(api, APFloat::rmTowardZero, &ignored)) {
       // Undefined behavior invoked - the destination type can't represent
@@ -969,7 +969,7 @@ OpFoldResult arith::FPToSIOp::fold(ArrayRef<Attribute> operands) {
     const APFloat &apf = lhs.getValue();
     IntegerType intTy = getType().cast<IntegerType>();
     bool ignored;
-    APSInt api(intTy.getWidth(), /*unsigned=*/false);
+    APSInt api(intTy.getWidth(), /*isUnsigned=*/false);
     if (APFloat::opInvalidOp ==
         apf.convertToInteger(api, APFloat::rmTowardZero, &ignored)) {
       // Undefined behavior invoked - the destination type can't represent


        


More information about the Mlir-commits mailing list