[Mlir-commits] [mlir] 89de9cc - Apply clang-tidy fixes for performance-for-range-copy to MLIR (NFC)
Mehdi Amini
llvmlistbot at llvm.org
Sat Jan 1 17:16:48 PST 2022
Author: Mehdi Amini
Date: 2022-01-02T01:13:42Z
New Revision: 89de9cc8a772a4e541547d6cc542583b34bed5b8
URL: https://github.com/llvm/llvm-project/commit/89de9cc8a772a4e541547d6cc542583b34bed5b8
DIFF: https://github.com/llvm/llvm-project/commit/89de9cc8a772a4e541547d6cc542583b34bed5b8.diff
LOG: Apply clang-tidy fixes for performance-for-range-copy to MLIR (NFC)
Differential Revision: https://reviews.llvm.org/D116248
Added:
Modified:
mlir/lib/Dialect/Async/Transforms/AsyncRuntimeRefCounting.cpp
mlir/lib/Dialect/Math/Transforms/PolynomialApproximation.cpp
mlir/lib/Dialect/StandardOps/Transforms/DecomposeCallGraphTypes.cpp
mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
mlir/lib/Dialect/Tosa/Transforms/TosaInferShapes.cpp
mlir/lib/Dialect/Utils/ReshapeOpsUtils.cpp
mlir/test/lib/Dialect/Test/TestPatterns.cpp
mlir/test/lib/IR/TestPrintDefUse.cpp
mlir/test/lib/IR/TestSlicing.cpp
mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp
mlir/tools/mlir-tblgen/AttrOrTypeFormatGen.cpp
mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp
mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
mlir/tools/mlir-tblgen/OpDocGen.cpp
mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp
Removed:
################################################################################
diff --git a/mlir/lib/Dialect/Async/Transforms/AsyncRuntimeRefCounting.cpp b/mlir/lib/Dialect/Async/Transforms/AsyncRuntimeRefCounting.cpp
index 4b4217a946161..81fa42438c322 100644
--- a/mlir/lib/Dialect/Async/Transforms/AsyncRuntimeRefCounting.cpp
+++ b/mlir/lib/Dialect/Async/Transforms/AsyncRuntimeRefCounting.cpp
@@ -418,7 +418,7 @@ AsyncRuntimeRefCountingPass::addDropRefInDivergentLivenessSuccessor(
continue;
// Update terminator `successor` block to `refCountingBlock`.
- for (auto pair : llvm::enumerate(terminator->getSuccessors()))
+ for (const auto &pair : llvm::enumerate(terminator->getSuccessors()))
if (pair.value() == successor)
terminator->setSuccessor(refCountingBlock, pair.index());
}
diff --git a/mlir/lib/Dialect/Math/Transforms/PolynomialApproximation.cpp b/mlir/lib/Dialect/Math/Transforms/PolynomialApproximation.cpp
index dc92436b97be0..2dbee7eaac6f7 100644
--- a/mlir/lib/Dialect/Math/Transforms/PolynomialApproximation.cpp
+++ b/mlir/lib/Dialect/Math/Transforms/PolynomialApproximation.cpp
@@ -134,7 +134,7 @@ handleMultidimensionalVectors(ImplicitLocOpBuilder &builder,
auto offsets = delinearize(strides, i);
SmallVector<Value> extracted(expandedOperands.size());
- for (auto tuple : llvm::enumerate(expandedOperands))
+ for (const auto &tuple : llvm::enumerate(expandedOperands))
extracted[tuple.index()] =
builder.create<vector::ExtractOp>(tuple.value(), offsets);
diff --git a/mlir/lib/Dialect/StandardOps/Transforms/DecomposeCallGraphTypes.cpp b/mlir/lib/Dialect/StandardOps/Transforms/DecomposeCallGraphTypes.cpp
index 3686568244e2f..f9d9c5c31e669 100644
--- a/mlir/lib/Dialect/StandardOps/Transforms/DecomposeCallGraphTypes.cpp
+++ b/mlir/lib/Dialect/StandardOps/Transforms/DecomposeCallGraphTypes.cpp
@@ -67,7 +67,7 @@ struct DecomposeCallGraphTypesForFuncArgs
// Convert function arguments using the provided TypeConverter.
TypeConverter::SignatureConversion conversion(functionType.getNumInputs());
- for (auto argType : llvm::enumerate(functionType.getInputs())) {
+ for (const auto &argType : llvm::enumerate(functionType.getInputs())) {
SmallVector<Type, 2> decomposedTypes;
if (failed(typeConverter->convertType(argType.value(), decomposedTypes)))
return failure();
diff --git a/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp b/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
index e56f83b8044e6..69da41c343709 100644
--- a/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
+++ b/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
@@ -1791,7 +1791,7 @@ LogicalResult IfOp::inferReturnTypeComponents(
if (resultKnowledge.size() != yieldOp.getNumOperands())
return failure();
- for (auto it : llvm::enumerate(yieldOp.getOperands())) {
+ for (const auto &it : llvm::enumerate(yieldOp.getOperands())) {
int32_t index = it.index();
auto meet = ValueKnowledge::meet(
resultKnowledge[index],
@@ -1835,7 +1835,7 @@ LogicalResult WhileOp::inferReturnTypeComponents(
if (resultKnowledge.size() != yieldOp.getNumOperands())
return failure();
- for (auto it : llvm::enumerate(yieldOp.getOperands())) {
+ for (const auto &it : llvm::enumerate(yieldOp.getOperands())) {
int32_t index = it.index();
if (auto meet = ValueKnowledge::meet(
resultKnowledge[index],
diff --git a/mlir/lib/Dialect/Tosa/Transforms/TosaInferShapes.cpp b/mlir/lib/Dialect/Tosa/Transforms/TosaInferShapes.cpp
index 34d480c3917e0..3a50336c3d4ab 100644
--- a/mlir/lib/Dialect/Tosa/Transforms/TosaInferShapes.cpp
+++ b/mlir/lib/Dialect/Tosa/Transforms/TosaInferShapes.cpp
@@ -132,7 +132,7 @@ void propagateShapesToTosaWhile(
}
for (auto yieldOp : yieldOps) {
- for (auto it : llvm::enumerate(yieldOp.getOperands())) {
+ for (const auto &it : llvm::enumerate(yieldOp.getOperands())) {
auto newKnowledge =
ValueKnowledge::getKnowledgeFromType(it.value().getType());
yieldTypeInfo[it.index()] =
diff --git a/mlir/lib/Dialect/Utils/ReshapeOpsUtils.cpp b/mlir/lib/Dialect/Utils/ReshapeOpsUtils.cpp
index f1acfb3ab5042..ddba1d3c44328 100644
--- a/mlir/lib/Dialect/Utils/ReshapeOpsUtils.cpp
+++ b/mlir/lib/Dialect/Utils/ReshapeOpsUtils.cpp
@@ -253,7 +253,7 @@ bool mlir::isReassociationValid(ArrayRef<AffineMap> reassociation,
return true;
unsigned nDims = reassociation[0].getNumDims();
unsigned nextExpectedDim = 0;
- for (auto it : llvm::enumerate(reassociation)) {
+ for (const auto &it : llvm::enumerate(reassociation)) {
auto m = it.value();
if (m.getNumDims() != nDims || m.getNumSymbols() != 0) {
if (invalidIndex)
diff --git a/mlir/test/lib/Dialect/Test/TestPatterns.cpp b/mlir/test/lib/Dialect/Test/TestPatterns.cpp
index 2f06d82bd521b..17a58713763d6 100644
--- a/mlir/test/lib/Dialect/Test/TestPatterns.cpp
+++ b/mlir/test/lib/Dialect/Test/TestPatterns.cpp
@@ -182,7 +182,7 @@ static void reifyReturnShape(Operation *op) {
if (failed(shapedOp.reifyReturnTypeShapes(b, op->getOperands(), shapes)) ||
!llvm::hasSingleElement(shapes))
return;
- for (auto it : llvm::enumerate(shapes)) {
+ for (const auto &it : llvm::enumerate(shapes)) {
op->emitRemark() << "value " << it.index() << ": "
<< it.value().getDefiningOp();
}
diff --git a/mlir/test/lib/IR/TestPrintDefUse.cpp b/mlir/test/lib/IR/TestPrintDefUse.cpp
index 6fa37b9cec739..8a854e6a059d6 100644
--- a/mlir/test/lib/IR/TestPrintDefUse.cpp
+++ b/mlir/test/lib/IR/TestPrintDefUse.cpp
@@ -41,7 +41,7 @@ struct TestPrintDefUsePass
// Print information about the user of each of the result.
llvm::outs() << "Has " << op->getNumResults() << " results:\n";
- for (auto indexedResult : llvm::enumerate(op->getResults())) {
+ for (const auto &indexedResult : llvm::enumerate(op->getResults())) {
Value result = indexedResult.value();
llvm::outs() << " - Result " << indexedResult.index();
if (result.use_empty()) {
diff --git a/mlir/test/lib/IR/TestSlicing.cpp b/mlir/test/lib/IR/TestSlicing.cpp
index 2489b14c6875b..a253c59706014 100644
--- a/mlir/test/lib/IR/TestSlicing.cpp
+++ b/mlir/test/lib/IR/TestSlicing.cpp
@@ -33,7 +33,7 @@ static LogicalResult createBackwardSliceFunction(Operation *op,
builder.create<FuncOp>(loc, clonedFuncOpName, parentFuncOp.getType());
BlockAndValueMapping mapper;
builder.setInsertionPointToEnd(clonedFuncOp.addEntryBlock());
- for (auto arg : enumerate(parentFuncOp.getArguments()))
+ for (const auto &arg : enumerate(parentFuncOp.getArguments()))
mapper.map(arg.value(), clonedFuncOp.getArgument(arg.index()));
SetVector<Operation *> slice;
getBackwardSlice(op, &slice);
diff --git a/mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp b/mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
index a07ada3c8e666..ed0b5f403f963 100644
--- a/mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
+++ b/mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
@@ -360,7 +360,7 @@ static std::string interleaveToString(Container &container,
static Optional<int>
findTensorDefArgIndex(StringRef name, SmallVectorImpl<LinalgOperandDef> &args) {
- for (auto it : llvm::enumerate(args)) {
+ for (const auto &it : llvm::enumerate(args)) {
if (it.value().name == name)
return it.index();
}
@@ -381,7 +381,7 @@ findTypeValue(StringRef typeVar, SmallVectorImpl<LinalgOperandDef> &args) {
return std::string("helper.getFloat64Type()");
// Search all argument types.
- for (auto it : llvm::enumerate(args)) {
+ for (const auto &it : llvm::enumerate(args)) {
if (it.value().typeVar == typeVar)
return llvm::formatv("block.getArgument({0}).getType()", it.index())
.str();
diff --git a/mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp b/mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp
index eac8e5638bada..d90adbc47ef4d 100644
--- a/mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp
+++ b/mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp
@@ -561,7 +561,7 @@ void DefGen::emitConstruct() {
MethodParameter("const KeyTy &", "tblgenKey"));
if (!def.hasStorageCustomConstructor()) {
auto &body = construct->body().indent();
- for (auto it : llvm::enumerate(params)) {
+ for (const auto &it : llvm::enumerate(params)) {
body << formatv("auto {0} = std::get<{1}>(tblgenKey);\n",
it.value().getName(), it.index());
}
diff --git a/mlir/tools/mlir-tblgen/AttrOrTypeFormatGen.cpp b/mlir/tools/mlir-tblgen/AttrOrTypeFormatGen.cpp
index 8042ecc6fe969..4a07157b884dd 100644
--- a/mlir/tools/mlir-tblgen/AttrOrTypeFormatGen.cpp
+++ b/mlir/tools/mlir-tblgen/AttrOrTypeFormatGen.cpp
@@ -661,7 +661,7 @@ FailureOr<std::unique_ptr<Element>> FormatParser::parseParamsDirective() {
/// Collect all of the attribute's or type's parameters.
SmallVector<std::unique_ptr<Element>> vars;
/// Ensure that none of the parameters have already been captured.
- for (auto it : llvm::enumerate(def.getParameters())) {
+ for (const auto &it : llvm::enumerate(def.getParameters())) {
if (seenParams.test(it.index())) {
return emitError("`params` captures duplicate parameter: " +
it.value().getName());
diff --git a/mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp b/mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp
index 18315ec366a0a..646527d1bdcc8 100644
--- a/mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp
+++ b/mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp
@@ -65,7 +65,7 @@ static IndicesTy getOverloadableTypeIdxs(const llvm::Record &record,
const char *listName) {
auto results = record.getValueAsListOfDefs(listName);
IndicesTy overloadedOps(results.size());
- for (auto r : llvm::enumerate(results)) {
+ for (const auto &r : llvm::enumerate(results)) {
llvm::MVT::SimpleValueType vt = getValueType(r.value());
switch (vt) {
case llvm::MVT::iAny:
diff --git a/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp b/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
index 484bb230e6b06..f27b537d63622 100644
--- a/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
+++ b/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
@@ -2267,7 +2267,7 @@ void OpEmitter::genOperandResultVerifier(MethodBody &body,
body << " {\n unsigned index = 0; (void)index;\n";
- for (auto staticValue : llvm::enumerate(values)) {
+ for (const auto &staticValue : llvm::enumerate(values)) {
const NamedTypeConstraint &value = staticValue.value();
bool hasPredicate = value.hasPredicate();
@@ -2332,7 +2332,7 @@ void OpEmitter::genRegionVerifier(MethodBody &body) {
return;
body << " {\n unsigned index = 0; (void)index;\n";
- for (auto it : llvm::enumerate(regions)) {
+ for (const auto &it : llvm::enumerate(regions)) {
const auto ®ion = it.value();
if (canSkip(region))
continue;
diff --git a/mlir/tools/mlir-tblgen/OpDocGen.cpp b/mlir/tools/mlir-tblgen/OpDocGen.cpp
index fc2f814176303..3025df140ea95 100644
--- a/mlir/tools/mlir-tblgen/OpDocGen.cpp
+++ b/mlir/tools/mlir-tblgen/OpDocGen.cpp
@@ -235,7 +235,7 @@ static void emitAttrOrTypeDefAssemblyFormat(const AttrOrTypeDef &def,
os << "\nSyntax:\n\n```\n!" << def.getDialect().getName() << "."
<< def.getMnemonic() << "<\n";
- for (auto it : llvm::enumerate(parameters)) {
+ for (const auto &it : llvm::enumerate(parameters)) {
const AttrOrTypeParameter ¶m = it.value();
os << " " << param.getSyntax();
if (it.index() < (parameters.size() - 1))
diff --git a/mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp b/mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp
index fb634a1be3957..16fccff973ca7 100644
--- a/mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp
+++ b/mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp
@@ -916,7 +916,7 @@ static void emitRegionAttributes(const Operator &op, raw_ostream &os) {
/// Emits named accessors to regions.
static void emitRegionAccessors(const Operator &op, raw_ostream &os) {
- for (auto en : llvm::enumerate(op.getRegions())) {
+ for (const auto &en : llvm::enumerate(op.getRegions())) {
const NamedRegion ®ion = en.value();
if (region.name.empty())
continue;
More information about the Mlir-commits
mailing list