[Mlir-commits] [mlir] 3bab9d4 - Apply clang-tidy fixes for bugprone-copy-constructor-init to MLIR (NFC)
Mehdi Amini
llvmlistbot at llvm.org
Sat Jan 1 17:09:39 PST 2022
Author: Mehdi Amini
Date: 2022-01-02T01:05:30Z
New Revision: 3bab9d4eb0913e07f453361b2104f85dc0c2fc3d
URL: https://github.com/llvm/llvm-project/commit/3bab9d4eb0913e07f453361b2104f85dc0c2fc3d
DIFF: https://github.com/llvm/llvm-project/commit/3bab9d4eb0913e07f453361b2104f85dc0c2fc3d.diff
LOG: Apply clang-tidy fixes for bugprone-copy-constructor-init to MLIR (NFC)
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116245
Added:
Modified:
mlir/lib/Dialect/Linalg/Transforms/ComprehensiveBufferizePass.cpp
mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp
mlir/test/lib/Dialect/Affine/TestAffineDataCopy.cpp
mlir/test/lib/Dialect/Affine/TestAffineLoopUnswitching.cpp
mlir/test/lib/Dialect/Affine/TestLoopPermutation.cpp
mlir/test/lib/Dialect/Linalg/TestComprehensiveBufferize.cpp
mlir/test/lib/Dialect/Linalg/TestLinalgCodegenStrategy.cpp
mlir/test/lib/Dialect/Linalg/TestLinalgDistribution.cpp
mlir/test/lib/Dialect/Linalg/TestLinalgFusionTransforms.cpp
mlir/test/lib/Dialect/Linalg/TestLinalgHoisting.cpp
mlir/test/lib/Dialect/Linalg/TestLinalgTransforms.cpp
mlir/test/lib/Dialect/Math/TestPolynomialApproximation.cpp
mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp
Removed:
################################################################################
diff --git a/mlir/lib/Dialect/Linalg/Transforms/ComprehensiveBufferizePass.cpp b/mlir/lib/Dialect/Linalg/Transforms/ComprehensiveBufferizePass.cpp
index 61a9f1b0cdb3b..6425c058f0b89 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/ComprehensiveBufferizePass.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/ComprehensiveBufferizePass.cpp
@@ -36,7 +36,8 @@ struct LinalgComprehensiveModuleBufferize
LinalgComprehensiveModuleBufferize() = default;
LinalgComprehensiveModuleBufferize(
- const LinalgComprehensiveModuleBufferize &p) {}
+ const LinalgComprehensiveModuleBufferize &p)
+ : LinalgComprehensiveModuleBufferizeBase(p) {}
void runOnOperation() override;
diff --git a/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp b/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp
index 8404aa6213387..61d90c031f3db 100644
--- a/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp
+++ b/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp
@@ -34,7 +34,7 @@ struct SparsificationPass : public SparsificationBase<SparsificationPass> {
SparsificationPass() = default;
SparsificationPass(const SparsificationPass &pass)
- : SparsificationBase<SparsificationPass>() {}
+ : SparsificationBase<SparsificationPass>(pass) {}
/// Returns parallelization strategy given on command line.
SparseParallelizationStrategy parallelOption() {
diff --git a/mlir/test/lib/Dialect/Affine/TestAffineDataCopy.cpp b/mlir/test/lib/Dialect/Affine/TestAffineDataCopy.cpp
index df74cf71ed538..e28b0c38f0ff0 100644
--- a/mlir/test/lib/Dialect/Affine/TestAffineDataCopy.cpp
+++ b/mlir/test/lib/Dialect/Affine/TestAffineDataCopy.cpp
@@ -34,7 +34,7 @@ struct TestAffineDataCopy
return "Tests affine data copy utility functions.";
}
TestAffineDataCopy() = default;
- TestAffineDataCopy(const TestAffineDataCopy &pass){};
+ TestAffineDataCopy(const TestAffineDataCopy &pass) : PassWrapper(pass){};
void getDependentDialects(DialectRegistry ®istry) const override {
registry.insert<memref::MemRefDialect>();
diff --git a/mlir/test/lib/Dialect/Affine/TestAffineLoopUnswitching.cpp b/mlir/test/lib/Dialect/Affine/TestAffineLoopUnswitching.cpp
index 542e109ebbb81..533b51eade973 100644
--- a/mlir/test/lib/Dialect/Affine/TestAffineLoopUnswitching.cpp
+++ b/mlir/test/lib/Dialect/Affine/TestAffineLoopUnswitching.cpp
@@ -30,7 +30,8 @@ struct TestAffineLoopUnswitching
return "Tests affine loop unswitching / if/else hoisting";
}
TestAffineLoopUnswitching() = default;
- TestAffineLoopUnswitching(const TestAffineLoopUnswitching &pass) {}
+ TestAffineLoopUnswitching(const TestAffineLoopUnswitching &pass)
+ : PassWrapper(pass) {}
void runOnFunction() override;
diff --git a/mlir/test/lib/Dialect/Affine/TestLoopPermutation.cpp b/mlir/test/lib/Dialect/Affine/TestLoopPermutation.cpp
index 8a88d15a42552..1a997dc60e9af 100644
--- a/mlir/test/lib/Dialect/Affine/TestLoopPermutation.cpp
+++ b/mlir/test/lib/Dialect/Affine/TestLoopPermutation.cpp
@@ -32,7 +32,7 @@ struct TestLoopPermutation
return "Tests affine loop permutation utility";
}
TestLoopPermutation() = default;
- TestLoopPermutation(const TestLoopPermutation &pass){};
+ TestLoopPermutation(const TestLoopPermutation &pass) : PassWrapper(pass){};
void runOnFunction() override;
diff --git a/mlir/test/lib/Dialect/Linalg/TestComprehensiveBufferize.cpp b/mlir/test/lib/Dialect/Linalg/TestComprehensiveBufferize.cpp
index 53d241286a09f..d54948e23844d 100644
--- a/mlir/test/lib/Dialect/Linalg/TestComprehensiveBufferize.cpp
+++ b/mlir/test/lib/Dialect/Linalg/TestComprehensiveBufferize.cpp
@@ -49,7 +49,8 @@ struct TestComprehensiveFunctionBufferize
TestComprehensiveFunctionBufferize() = default;
TestComprehensiveFunctionBufferize(
- const TestComprehensiveFunctionBufferize &pass) {}
+ const TestComprehensiveFunctionBufferize &pass)
+ : PassWrapper(pass) {}
void getDependentDialects(DialectRegistry ®istry) const override {
registry.insert<bufferization::BufferizationDialect, linalg::LinalgDialect,
diff --git a/mlir/test/lib/Dialect/Linalg/TestLinalgCodegenStrategy.cpp b/mlir/test/lib/Dialect/Linalg/TestLinalgCodegenStrategy.cpp
index 92cbe66e4a073..d798042bfac80 100644
--- a/mlir/test/lib/Dialect/Linalg/TestLinalgCodegenStrategy.cpp
+++ b/mlir/test/lib/Dialect/Linalg/TestLinalgCodegenStrategy.cpp
@@ -33,7 +33,8 @@ struct TestLinalgCodegenStrategy
return "Test Linalg Codegen Strategy.";
}
TestLinalgCodegenStrategy() = default;
- TestLinalgCodegenStrategy(const TestLinalgCodegenStrategy &pass) {}
+ TestLinalgCodegenStrategy(const TestLinalgCodegenStrategy &pass)
+ : PassWrapper(pass) {}
void getDependentDialects(DialectRegistry ®istry) const override {
// clang-format off
diff --git a/mlir/test/lib/Dialect/Linalg/TestLinalgDistribution.cpp b/mlir/test/lib/Dialect/Linalg/TestLinalgDistribution.cpp
index 70464b524d2c1..fa982e7fb3c28 100644
--- a/mlir/test/lib/Dialect/Linalg/TestLinalgDistribution.cpp
+++ b/mlir/test/lib/Dialect/Linalg/TestLinalgDistribution.cpp
@@ -43,7 +43,8 @@ struct TestLinalgDistribution
StringRef getArgument() const final { return "test-linalg-distribution"; }
StringRef getDescription() const final { return "Test Linalg distribution."; }
TestLinalgDistribution() = default;
- TestLinalgDistribution(const TestLinalgDistribution &pass) {}
+ TestLinalgDistribution(const TestLinalgDistribution &pass)
+ : PassWrapper(pass) {}
void getDependentDialects(DialectRegistry ®istry) const override {
registry.insert<AffineDialect, gpu::GPUDialect>();
}
diff --git a/mlir/test/lib/Dialect/Linalg/TestLinalgFusionTransforms.cpp b/mlir/test/lib/Dialect/Linalg/TestLinalgFusionTransforms.cpp
index 39f8cca3c1125..d5391a1b3b3e0 100644
--- a/mlir/test/lib/Dialect/Linalg/TestLinalgFusionTransforms.cpp
+++ b/mlir/test/lib/Dialect/Linalg/TestLinalgFusionTransforms.cpp
@@ -264,7 +264,8 @@ struct TestLinalgTileAndFuseSequencePass
}
TestLinalgTileAndFuseSequencePass() = default;
TestLinalgTileAndFuseSequencePass(
- const TestLinalgTileAndFuseSequencePass &pass){};
+ const TestLinalgTileAndFuseSequencePass &pass)
+ : PassWrapper(pass){};
ListOption<int64_t> tileSizes{
*this, "tile-sizes", llvm::cl::desc("Tile sizes to use for ops"),
diff --git a/mlir/test/lib/Dialect/Linalg/TestLinalgHoisting.cpp b/mlir/test/lib/Dialect/Linalg/TestLinalgHoisting.cpp
index 59b13b93e2a41..4fa90ede1a987 100644
--- a/mlir/test/lib/Dialect/Linalg/TestLinalgHoisting.cpp
+++ b/mlir/test/lib/Dialect/Linalg/TestLinalgHoisting.cpp
@@ -22,7 +22,7 @@ namespace {
struct TestLinalgHoisting
: public PassWrapper<TestLinalgHoisting, FunctionPass> {
TestLinalgHoisting() = default;
- TestLinalgHoisting(const TestLinalgHoisting &pass) {}
+ TestLinalgHoisting(const TestLinalgHoisting &pass) : PassWrapper(pass) {}
void getDependentDialects(DialectRegistry ®istry) const override {
registry.insert<AffineDialect>();
}
diff --git a/mlir/test/lib/Dialect/Linalg/TestLinalgTransforms.cpp b/mlir/test/lib/Dialect/Linalg/TestLinalgTransforms.cpp
index d24de7a13fe1d..51cdd8732140d 100644
--- a/mlir/test/lib/Dialect/Linalg/TestLinalgTransforms.cpp
+++ b/mlir/test/lib/Dialect/Linalg/TestLinalgTransforms.cpp
@@ -34,7 +34,7 @@ namespace {
struct TestLinalgTransforms
: public PassWrapper<TestLinalgTransforms, FunctionPass> {
TestLinalgTransforms() = default;
- TestLinalgTransforms(const TestLinalgTransforms &pass) {}
+ TestLinalgTransforms(const TestLinalgTransforms &pass) : PassWrapper(pass) {}
void getDependentDialects(DialectRegistry ®istry) const override {
// clang-format off
diff --git a/mlir/test/lib/Dialect/Math/TestPolynomialApproximation.cpp b/mlir/test/lib/Dialect/Math/TestPolynomialApproximation.cpp
index 7cce0ef907e7a..486ea582cb768 100644
--- a/mlir/test/lib/Dialect/Math/TestPolynomialApproximation.cpp
+++ b/mlir/test/lib/Dialect/Math/TestPolynomialApproximation.cpp
@@ -26,7 +26,8 @@ struct TestMathPolynomialApproximationPass
: public PassWrapper<TestMathPolynomialApproximationPass, FunctionPass> {
TestMathPolynomialApproximationPass() = default;
TestMathPolynomialApproximationPass(
- const TestMathPolynomialApproximationPass &pass) {}
+ const TestMathPolynomialApproximationPass &pass)
+ : PassWrapper(pass) {}
void runOnFunction() override;
void getDependentDialects(DialectRegistry ®istry) const override {
diff --git a/mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp b/mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp
index e0902db67370d..db52be8dcff5a 100644
--- a/mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp
+++ b/mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp
@@ -31,7 +31,8 @@ namespace {
struct TestVectorToVectorLowering
: public PassWrapper<TestVectorToVectorLowering, FunctionPass> {
TestVectorToVectorLowering() = default;
- TestVectorToVectorLowering(const TestVectorToVectorLowering &pass) {}
+ TestVectorToVectorLowering(const TestVectorToVectorLowering &pass)
+ : PassWrapper(pass) {}
StringRef getArgument() const final {
return "test-vector-to-vector-lowering";
}
@@ -110,7 +111,8 @@ struct TestVectorContractionLowering
"dialect";
}
TestVectorContractionLowering() = default;
- TestVectorContractionLowering(const TestVectorContractionLowering &pass) {}
+ TestVectorContractionLowering(const TestVectorContractionLowering &pass)
+ : PassWrapper(pass) {}
Option<bool> lowerToFlatMatrix{
*this, "vector-lower-matrix-intrinsics",
@@ -182,7 +184,8 @@ struct TestVectorTransposeLowering
"dialect";
}
TestVectorTransposeLowering() = default;
- TestVectorTransposeLowering(const TestVectorTransposeLowering &pass) {}
+ TestVectorTransposeLowering(const TestVectorTransposeLowering &pass)
+ : PassWrapper(pass) {}
Option<bool> lowerToEltwise{
*this, "eltwise",
@@ -253,7 +256,8 @@ struct TestVectorUnrollingPatterns
"dialect";
}
TestVectorUnrollingPatterns() = default;
- TestVectorUnrollingPatterns(const TestVectorUnrollingPatterns &pass) {}
+ TestVectorUnrollingPatterns(const TestVectorUnrollingPatterns &pass)
+ : PassWrapper(pass) {}
void runOnFunction() override {
MLIRContext *ctx = &getContext();
RewritePatternSet patterns(ctx);
@@ -312,7 +316,8 @@ struct TestVectorDistributePatterns
"dialect";
}
TestVectorDistributePatterns() = default;
- TestVectorDistributePatterns(const TestVectorDistributePatterns &pass) {}
+ TestVectorDistributePatterns(const TestVectorDistributePatterns &pass)
+ : PassWrapper(pass) {}
void getDependentDialects(DialectRegistry ®istry) const override {
registry.insert<VectorDialect>();
registry.insert<AffineDialect>();
@@ -365,7 +370,8 @@ struct TestVectorToLoopPatterns
return "Test lowering patterns to break up a vector op into a for loop";
}
TestVectorToLoopPatterns() = default;
- TestVectorToLoopPatterns(const TestVectorToLoopPatterns &pass) {}
+ TestVectorToLoopPatterns(const TestVectorToLoopPatterns &pass)
+ : PassWrapper(pass) {}
void getDependentDialects(DialectRegistry ®istry) const override {
registry.insert<VectorDialect>();
registry.insert<AffineDialect>();
@@ -456,7 +462,8 @@ struct TestVectorTransferFullPartialSplitPatterns
}
TestVectorTransferFullPartialSplitPatterns() = default;
TestVectorTransferFullPartialSplitPatterns(
- const TestVectorTransferFullPartialSplitPatterns &pass) {}
+ const TestVectorTransferFullPartialSplitPatterns &pass)
+ : PassWrapper(pass) {}
void getDependentDialects(DialectRegistry ®istry) const override {
registry.insert<AffineDialect, linalg::LinalgDialect, memref::MemRefDialect,
@@ -514,7 +521,8 @@ struct TestVectorMultiReductionLoweringPatterns
FunctionPass> {
TestVectorMultiReductionLoweringPatterns() = default;
TestVectorMultiReductionLoweringPatterns(
- const TestVectorMultiReductionLoweringPatterns &pass) {}
+ const TestVectorMultiReductionLoweringPatterns &pass)
+ : PassWrapper(pass) {}
void getDependentDialects(DialectRegistry ®istry) const override {
registry.insert<memref::MemRefDialect>();
}
@@ -544,7 +552,8 @@ struct TestVectorTransferCollapseInnerMostContiguousDims
FunctionPass> {
TestVectorTransferCollapseInnerMostContiguousDims() = default;
TestVectorTransferCollapseInnerMostContiguousDims(
- const TestVectorTransferCollapseInnerMostContiguousDims &pass) {}
+ const TestVectorTransferCollapseInnerMostContiguousDims &pass)
+ : PassWrapper(pass) {}
void getDependentDialects(DialectRegistry ®istry) const override {
registry.insert<memref::MemRefDialect, AffineDialect>();
More information about the Mlir-commits
mailing list