[Mlir-commits] [mlir] e7f4ea8 - [MLIR][Pass] Have PassRegistryEntry own pass strings

Daniel Resnick llvmlistbot at llvm.org
Wed Feb 23 09:04:29 PST 2022


Author: Daniel Resnick
Date: 2022-02-23T10:04:04-07:00
New Revision: e7f4ea8abeed5063ea21e508d85ef104be8e4505

URL: https://github.com/llvm/llvm-project/commit/e7f4ea8abeed5063ea21e508d85ef104be8e4505
DIFF: https://github.com/llvm/llvm-project/commit/e7f4ea8abeed5063ea21e508d85ef104be8e4505.diff

LOG: [MLIR][Pass] Have PassRegistryEntry own pass strings

This eliminates the requirement that pass-related strings outlive pass
instances, which will facilitate future work enabling dynamic passes
written in other languages.

Differential Revision: https://reviews.llvm.org/D120341

Added: 
    

Modified: 
    mlir/include/mlir/Pass/PassRegistry.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Pass/PassRegistry.h b/mlir/include/mlir/Pass/PassRegistry.h
index 9167751ebbcee..496bac77476a3 100644
--- a/mlir/include/mlir/Pass/PassRegistry.h
+++ b/mlir/include/mlir/Pass/PassRegistry.h
@@ -81,10 +81,10 @@ class PassRegistryEntry {
 
 private:
   /// The argument with which to invoke the pass via mlir-opt.
-  StringRef arg;
+  std::string arg;
 
   /// Description of the pass.
-  StringRef description;
+  std::string description;
 
   /// Function to register this entry to a pass manager pipeline.
   PassRegistryFunction builder;


        


More information about the Mlir-commits mailing list