[Mlir-commits] [mlir] de2cc2a - Reland "[mlir][pdl] NFC re-add NoSideEffect to Result and Results Op"

[Reid Kleckner]

Author: Reid Kleckner
Date: 2022-02-22T10:48:25-08:00
New Revision: de2cc2a00298a952aeee1883086e4c614259333a

URL: https://github.com/llvm/llvm-project/commit/de2cc2a00298a952aeee1883086e4c614259333a
DIFF: https://github.com/llvm/llvm-project/commit/de2cc2a00298a952aeee1883086e4c614259333a.diff

LOG: Reland "[mlir][pdl] NFC re-add NoSideEffect to Result and Results Op"

This reverts commit 9865c3f28aa812364584b55629eef9b52bb1230e.

Looks like our commits raced and Jeff fixed the build issue.

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/PDL/IR/PDLOps.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/PDL/IR/PDLOps.td b/mlir/include/mlir/Dialect/PDL/IR/PDLOps.td
index 206191a8ff78..61fe1261e6dd 100644
--- a/mlir/include/mlir/Dialect/PDL/IR/PDLOps.td
+++ b/mlir/include/mlir/Dialect/PDL/IR/PDLOps.td
@@ -501,7 +501,7 @@ def PDL_ReplaceOp : PDL_Op<"replace", [
 // pdl::ResultOp
 //===----------------------------------------------------------------------===//
 
-def PDL_ResultOp : PDL_Op<"result"> {
+def PDL_ResultOp : PDL_Op<"result", [NoSideEffect]> {
   let summary = "Extract a result from an operation";
   let description = [{
     `pdl.result` operations extract result edges from an operation node within
@@ -533,7 +533,7 @@ def PDL_ResultOp : PDL_Op<"result"> {
 // pdl::ResultsOp
 //===----------------------------------------------------------------------===//
 
-def PDL_ResultsOp : PDL_Op<"results"> {
+def PDL_ResultsOp : PDL_Op<"results", [NoSideEffect]> {
   let summary = "Extract a result group from an operation";
   let description = [{
     `pdl.results` operations extract a result group from an operation within a