[Mlir-commits] [mlir] 719b865 - [mlir][sparse][pytaco] add SDDMM test with two different ways of defining kernel

[Aart Bik]

Author: Aart Bik
Date: 2022-02-10T13:33:06-08:00
New Revision: 719b865be215c0b89fd0a8dec3bbe325427a6275

URL: https://github.com/llvm/llvm-project/commit/719b865be215c0b89fd0a8dec3bbe325427a6275
DIFF: https://github.com/llvm/llvm-project/commit/719b865be215c0b89fd0a8dec3bbe325427a6275.diff

LOG: [mlir][sparse][pytaco] add SDDMM test with two different ways of defining kernel

Reviewed By: bixia

Differential Revision: https://reviews.llvm.org/D119465

Added: 
    mlir/test/Integration/Dialect/SparseTensor/taco/test_SDDMM.py

Modified: 
    mlir/test/Integration/Dialect/SparseTensor/taco/tools/testing_utils.py

Removed: 
    


################################################################################
diff  --git a/mlir/test/Integration/Dialect/SparseTensor/taco/test_SDDMM.py b/mlir/test/Integration/Dialect/SparseTensor/taco/test_SDDMM.py
new file mode 100644
index 0000000000000..876e6bd073a09
--- /dev/null
+++ b/mlir/test/Integration/Dialect/SparseTensor/taco/test_SDDMM.py
@@ -0,0 +1,57 @@
+# RUN: SUPPORTLIB=%mlir_runner_utils_dir/libmlir_c_runner_utils%shlibext %PYTHON %s | FileCheck %s
+
+import filecmp
+import numpy as np
+import os
+import sys
+import tempfile
+
+_SCRIPT_PATH = os.path.dirname(os.path.abspath(__file__))
+sys.path.append(_SCRIPT_PATH)
+
+from tools import mlir_pytaco_api as pt
+from tools import testing_utils as utils
+
+i, j, k = pt.get_index_vars(3)
+
+# Set up dense matrices.
+A = pt.from_array(np.full((8, 8), 2.0))
+B = pt.from_array(np.full((8, 8), 3.0))
+
+# Set up sparse matrices.
+S = pt.tensor([8, 8], pt.format([pt.compressed, pt.compressed]))
+X = pt.tensor([8, 8], pt.format([pt.compressed, pt.compressed]))
+Y = pt.tensor([8, 8], pt.compressed)  # alternative syntax works too
+
+S.insert([0, 7], 42.0)
+
+# Define the SDDMM kernel. Since this performs the reduction as
+#   sum(k, S[i, j] * A[i, k] * B[k, j])
+# we only compute the intermediate dense matrix product that are actually
+# needed to compute the result, with proper asymptotic complexity.
+X[i, j] = S[i, j] * A[i, k] * B[k, j]
+
+# Alternative way to define SDDMM kernel. Since this performs the reduction as
+#   sum(k, A[i, k] * B[k, j]) * S[i, j]
+# the MLIR lowering results in two separate tensor index expressions that
+# need to be fused properly to guarantee proper asymptotic complexity.
+Y[i, j] = A[i, k] * B[k, j] * S[i, j]
+
+expected = """; extended FROSTT format
+2 1
+8 8
+1 8 2016
+"""
+
+# Force evaluation of the kernels by writing out X and Y.
+with tempfile.TemporaryDirectory() as test_dir:
+  x_file = os.path.join(test_dir, "X.tns")
+  y_file = os.path.join(test_dir, "Y.tns")
+  pt.write(x_file, X)
+  pt.write(y_file, Y)
+  #
+  # CHECK: Compare result True True
+  #
+  x_data = utils.file_as_string(x_file)
+  y_data = utils.file_as_string(y_file)
+  print(f"Compare result {x_data == expected} {y_data == expected}")

diff  --git a/mlir/test/Integration/Dialect/SparseTensor/taco/tools/testing_utils.py b/mlir/test/Integration/Dialect/SparseTensor/taco/tools/testing_utils.py
index 1e13bad262c40..02437b441556c 100644
--- a/mlir/test/Integration/Dialect/SparseTensor/taco/tools/testing_utils.py
+++ b/mlir/test/Integration/Dialect/SparseTensor/taco/tools/testing_utils.py
@@ -30,3 +30,9 @@ def compare_sparse_tns(expected: str, actual: str, rtol: float = 0.0001) -> bool
   actual_data = np.loadtxt(actual, np.float64, skiprows=3)
   expected_data = np.loadtxt(expected, np.float64, skiprows=3)
   return np.allclose(actual_data, expected_data, rtol=rtol)
+
+
+def file_as_string(file: str) -> str:
+  """Returns contents of file as string."""
+  with open(file, "r") as f:
+    return f.read()