[Mlir-commits] [mlir] 4d30a24 - [mlir] Remove MatrixBuilder template argument

Nikita Popov llvmlistbot at llvm.org
Mon Feb 7 07:52:17 PST 2022


Author: Nikita Popov
Date: 2022-02-07T16:52:10+01:00
New Revision: 4d30a245c9188166a6819db34269455ea75f318e

URL: https://github.com/llvm/llvm-project/commit/4d30a245c9188166a6819db34269455ea75f318e
DIFF: https://github.com/llvm/llvm-project/commit/4d30a245c9188166a6819db34269455ea75f318e.diff

LOG: [mlir] Remove MatrixBuilder template argument

I dropped this argument in cdc0573f753e639ed78f2a3645179ac2d2718fd0,
but did not adjust mlir. (Or rather I did, but I modified a generated
file ... oops)

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
index 66d28c713bcfa..164493720fe4f 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
+++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
@@ -1611,7 +1611,7 @@ def LLVM_MatrixColumnMajorLoadOp : LLVM_Op<"intr.matrix.column.major.load"> {
   let results = (outs LLVM_Type:$res);
   let builders = [LLVM_OneResultOpBuilder];
   string llvmBuilder = [{
-    llvm::MatrixBuilder<decltype(builder)> mb(builder);
+    llvm::MatrixBuilder mb(builder);
     const llvm::DataLayout &dl =
       builder.GetInsertBlock()->getModule()->getDataLayout();
     llvm::Align align = dl.getABITypeAlign(
@@ -1637,7 +1637,7 @@ def LLVM_MatrixColumnMajorStoreOp : LLVM_Op<"intr.matrix.column.major.store"> {
                    I1Attr:$isVolatile, I32Attr:$rows, I32Attr:$columns);
   let builders = [LLVM_VoidResultTypeOpBuilder, LLVM_ZeroResultOpBuilder];
   string llvmBuilder = [{
-    llvm::MatrixBuilder<decltype(builder)> mb(builder);
+    llvm::MatrixBuilder mb(builder);
     const llvm::DataLayout &dl =
       builder.GetInsertBlock()->getModule()->getDataLayout();
     llvm::Align align = dl.getABITypeAlign(
@@ -1658,7 +1658,7 @@ def LLVM_MatrixMultiplyOp : LLVM_Op<"intr.matrix.multiply"> {
   let results = (outs LLVM_Type:$res);
   let builders = [LLVM_OneResultOpBuilder];
   string llvmBuilder = [{
-    llvm::MatrixBuilder<decltype(builder)> mb(builder);
+    llvm::MatrixBuilder mb(builder);
     $res = mb.CreateMatrixMultiply(
       $lhs, $rhs, $lhs_rows, $lhs_columns,
       $rhs_columns);
@@ -1674,7 +1674,7 @@ def LLVM_MatrixTransposeOp : LLVM_Op<"intr.matrix.transpose"> {
   let results = (outs LLVM_Type:$res);
   let builders = [LLVM_OneResultOpBuilder];
   string llvmBuilder = [{
-    llvm::MatrixBuilder<decltype(builder)> mb(builder);
+    llvm::MatrixBuilder mb(builder);
     $res = mb.CreateMatrixTranspose(
       $matrix, $rows, $columns);
   }];


        


More information about the Mlir-commits mailing list