[Mlir-commits] [mlir] 947d529 - [mlir] NFC: work around gcc-aarch64 v8.3 compilation issue in getRegionBranchSuccessorOperands implementation.

[Christian Sigg]

Author: Christian Sigg
Date: 2022-12-29T12:03:32+01:00
New Revision: 947d529e4194e0567cfbbea99127066f76c87269

URL: https://github.com/llvm/llvm-project/commit/947d529e4194e0567cfbbea99127066f76c87269
DIFF: https://github.com/llvm/llvm-project/commit/947d529e4194e0567cfbbea99127066f76c87269.diff

LOG: [mlir] NFC: work around gcc-aarch64 v8.3 compilation issue in getRegionBranchSuccessorOperands implementation.

https://reviews.llvm.org/rG25671db3d343 didn't quite do it because the underlying issue was that the specific compiler chokes on the second standard conversion sequence after the user-defined `MutableOperandRange::operator OperandRange() const` conversion (see https://en.cppreference.com/w/cpp/language/implicit_conversion).

Added: 
    

Modified: 
    mlir/lib/Interfaces/ControlFlowInterfaces.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Interfaces/ControlFlowInterfaces.cpp b/mlir/lib/Interfaces/ControlFlowInterfaces.cpp
index 9df5e551e6a37..deec6058c1a0c 100644
--- a/mlir/lib/Interfaces/ControlFlowInterfaces.cpp
+++ b/mlir/lib/Interfaces/ControlFlowInterfaces.cpp
@@ -395,6 +395,6 @@ mlir::getRegionBranchSuccessorOperands(Operation *operation,
                                        std::optional<unsigned> regionIndex) {
   auto range = getMutableRegionBranchSuccessorOperands(operation, regionIndex);
   if (range)
-    return static_cast<OperandRange>(*range);
+    return range->operator OperandRange();
   return std::nullopt;
 }