[Mlir-commits] [mlir] 5ad919a - [mlir] [docs] Broken link in MLIR Toy docs
Jeff Niu
llvmlistbot at llvm.org
Tue Dec 6 12:15:05 PST 2022
Author: Wheest
Date: 2022-12-06T12:14:59-08:00
New Revision: 5ad919a1d6bbe449210f81e4ae7a5f765eb5a976
URL: https://github.com/llvm/llvm-project/commit/5ad919a1d6bbe449210f81e4ae7a5f765eb5a976
DIFF: https://github.com/llvm/llvm-project/commit/5ad919a1d6bbe449210f81e4ae7a5f765eb5a976.diff
LOG: [mlir] [docs] Broken link in MLIR Toy docs
In the Ch6 of the Toy Example for MLIR, there is a broken link. If ones goes to [the page for Chapter 6](https://mlir.llvm.org/docs/Tutorials/Toy/Ch-6/), and click on the link "Conversion to the LLVM IR Dialect", one will see it takes you to a page that no longer exists.
I believe this should actually be [this link](https://mlir.llvm.org/docs/TargetLLVMIR/).
Note to reviewers that this is my first submitted patch to LLVM, and using the phabricator system, so there is a higher risk that I have made an error, and brief feedback on these patch notes would be appreciated.
Reviewer rational: Users who git blame say contributed to the tutorial.
I believe that automated tests on these markdown docs could reduce the risk of this kind of error occurring again. For example, [this Python package](https://pypi.org/project/linkcheckmd/) checks for broken markdown links. However, I am unsure where in the existing testing infrastructure this could go, I am only somewhat familiar with the C++ side.
Reviewed By: Mogball
Differential Revision: https://reviews.llvm.org/D133977
Added:
Modified:
mlir/docs/Tutorials/Toy/Ch-6.md
Removed:
################################################################################
diff --git a/mlir/docs/Tutorials/Toy/Ch-6.md b/mlir/docs/Tutorials/Toy/Ch-6.md
index 7fa9db05a8246..e8a68b5f9ee38 100644
--- a/mlir/docs/Tutorials/Toy/Ch-6.md
+++ b/mlir/docs/Tutorials/Toy/Ch-6.md
@@ -171,7 +171,7 @@ llvm.func @main() {
}
```
-See [Conversion to the LLVM IR Dialect](../../ConversionToLLVMDialect.md) for
+See [LLVM IR Target](../../TargetLLVMIR.md) for
more in-depth details on lowering to the LLVM dialect.
## CodeGen: Getting Out of MLIR
More information about the Mlir-commits
mailing list