[Mlir-commits] [mlir] 6ed4310 - Apply clang-tidy fixes for readability-simplify-boolean-expr in SPIRVToLLVM.cpp (NFC)

Mehdi Amini llvmlistbot at llvm.org
Wed Aug 31 17:37:45 PDT 2022


Author: Mehdi Amini
Date: 2022-09-01T00:37:14Z
New Revision: 6ed4310e5cf408d243f0a37540f0a434bfb02613

URL: https://github.com/llvm/llvm-project/commit/6ed4310e5cf408d243f0a37540f0a434bfb02613
DIFF: https://github.com/llvm/llvm-project/commit/6ed4310e5cf408d243f0a37540f0a434bfb02613.diff

LOG: Apply clang-tidy fixes for readability-simplify-boolean-expr in SPIRVToLLVM.cpp (NFC)

Added: 
    

Modified: 
    mlir/lib/Conversion/SPIRVToLLVM/SPIRVToLLVM.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Conversion/SPIRVToLLVM/SPIRVToLLVM.cpp b/mlir/lib/Conversion/SPIRVToLLVM/SPIRVToLLVM.cpp
index 0a0e7b0723b1c..1d6ae56a6c96e 100644
--- a/mlir/lib/Conversion/SPIRVToLLVM/SPIRVToLLVM.cpp
+++ b/mlir/lib/Conversion/SPIRVToLLVM/SPIRVToLLVM.cpp
@@ -252,7 +252,7 @@ static Optional<Type> convertArrayType(spirv::ArrayType type,
   unsigned stride = type.getArrayStride();
   Type elementType = type.getElementType();
   auto sizeInBytes = elementType.cast<spirv::SPIRVType>().getSizeInBytes();
-  if (stride != 0 && !(sizeInBytes && *sizeInBytes == stride))
+  if (stride != 0 && (!sizeInBytes || *sizeInBytes != stride))
     return llvm::None;
 
   auto llvmElementType = converter.convertType(elementType);


        


More information about the Mlir-commits mailing list