[Mlir-commits] [mlir] 4a1b119 - Apply clang-tidy fixes for performance-unnecessary-value-param in IRAttributes.cpp (NFC)

[Mehdi Amini]

Author: Mehdi Amini
Date: 2022-08-29T12:33:05Z
New Revision: 4a1b119658aabe7cd1e41dd5be7bd7da51eacef5

URL: https://github.com/llvm/llvm-project/commit/4a1b119658aabe7cd1e41dd5be7bd7da51eacef5
DIFF: https://github.com/llvm/llvm-project/commit/4a1b119658aabe7cd1e41dd5be7bd7da51eacef5.diff

LOG: Apply clang-tidy fixes for performance-unnecessary-value-param in IRAttributes.cpp (NFC)

Added: 
    

Modified: 
    mlir/lib/Bindings/Python/IRAttributes.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Bindings/Python/IRAttributes.cpp b/mlir/lib/Bindings/Python/IRAttributes.cpp
index f9c7f6fe51937..8d8cea395e174 100644
--- a/mlir/lib/Bindings/Python/IRAttributes.cpp
+++ b/mlir/lib/Bindings/Python/IRAttributes.cpp
@@ -120,7 +120,7 @@ class PyDenseArrayAttribute : public PyConcreteAttribute<DerivedT> {
   /// Iterator over the integer elements of a dense array.
   class PyDenseArrayIterator {
   public:
-    PyDenseArrayIterator(PyAttribute attr) : attr(attr) {}
+    PyDenseArrayIterator(PyAttribute attr) : attr(std::move(attr)) {}
 
     /// Return a copy of the iterator.
     PyDenseArrayIterator dunderIter() { return *this; }
@@ -174,7 +174,7 @@ class PyDenseArrayAttribute : public PyConcreteAttribute<DerivedT> {
     });
     c.def("__iter__",
           [](const DerivedT &arr) { return PyDenseArrayIterator(arr); });
-    c.def("__add__", [](DerivedT &arr, py::list extras) {
+    c.def("__add__", [](DerivedT &arr, const py::list &extras) {
       std::vector<EltTy> values;
       intptr_t numOldElements = mlirDenseArrayGetNumElements(arr);
       values.reserve(numOldElements + py::len(extras));