[Mlir-commits] [mlir] df4e637 - [mlir:Bytecode] Use UNSUPPORTED instead of XFAIL for s390x

[River Riddle]

Author: River Riddle
Date: 2022-08-23T16:56:04-07:00
New Revision: df4e637ca7ef4ef17b662845120864921e65bb67

URL: https://github.com/llvm/llvm-project/commit/df4e637ca7ef4ef17b662845120864921e65bb67
DIFF: https://github.com/llvm/llvm-project/commit/df4e637ca7ef4ef17b662845120864921e65bb67.diff

LOG: [mlir:Bytecode] Use UNSUPPORTED instead of XFAIL for s390x

Some tests still pass even though we don't claim big-endian support. Using
UNSUPPORTED is a better indicator than XFAIL that we don't guarantee that
the tests work.

Added: 
    

Modified: 
    mlir/test/Bytecode/general.mlir
    mlir/test/Bytecode/invalid/invalid-dialect_section.mlir
    mlir/test/Bytecode/invalid/invalid-ir_section.mlir
    mlir/test/Bytecode/invalid/invalid-string_section.mlir
    mlir/test/Bytecode/invalid/invalid-structure.mlir
    mlir/test/Bytecode/invalid/invalid_attr_type_offset_section.mlir
    mlir/test/Bytecode/invalid/invalid_attr_type_section.mlir

Removed: 
    


################################################################################
diff  --git a/mlir/test/Bytecode/general.mlir b/mlir/test/Bytecode/general.mlir
index 1926fa652f17c..7943600c817d6 100644
--- a/mlir/test/Bytecode/general.mlir
+++ b/mlir/test/Bytecode/general.mlir
@@ -1,7 +1,7 @@
 // RUN: mlir-opt -allow-unregistered-dialect -emit-bytecode %s | mlir-opt -allow-unregistered-dialect | FileCheck %s
 
 // Bytecode currently does not support big-endian platforms
-// XFAIL: s390x-
+// UNSUPPORTED: s390x-
 
 // CHECK-LABEL: "bytecode.test1"
 // CHECK-NEXT:    "bytecode.empty"() : () -> ()

diff  --git a/mlir/test/Bytecode/invalid/invalid-dialect_section.mlir b/mlir/test/Bytecode/invalid/invalid-dialect_section.mlir
index fd9bd33f91fbe..8602ef39175cc 100644
--- a/mlir/test/Bytecode/invalid/invalid-dialect_section.mlir
+++ b/mlir/test/Bytecode/invalid/invalid-dialect_section.mlir
@@ -2,7 +2,7 @@
 // the dialect section.
 
 // Bytecode currently does not support big-endian platforms
-// XFAIL: s390x-
+// UNSUPPORTED: s390x-
 
 //===--------------------------------------------------------------------===//
 // Dialect Name

diff  --git a/mlir/test/Bytecode/invalid/invalid-ir_section.mlir b/mlir/test/Bytecode/invalid/invalid-ir_section.mlir
index 561e2f45839c1..d4ba6741c2b94 100644
--- a/mlir/test/Bytecode/invalid/invalid-ir_section.mlir
+++ b/mlir/test/Bytecode/invalid/invalid-ir_section.mlir
@@ -2,7 +2,7 @@
 // the IR section.
 
 // Bytecode currently does not support big-endian platforms
-// XFAIL: s390x-
+// UNSUPPORTED: s390x-
 
 //===--------------------------------------------------------------------===//
 // Operations

diff  --git a/mlir/test/Bytecode/invalid/invalid-string_section.mlir b/mlir/test/Bytecode/invalid/invalid-string_section.mlir
index 18c8ab73bdae3..13f71037e295f 100644
--- a/mlir/test/Bytecode/invalid/invalid-string_section.mlir
+++ b/mlir/test/Bytecode/invalid/invalid-string_section.mlir
@@ -2,7 +2,7 @@
 // the string section.
 
 // Bytecode currently does not support big-endian platforms
-// XFAIL: s390x-
+// UNSUPPORTED: s390x-
 
 //===--------------------------------------------------------------------===//
 // Count

diff  --git a/mlir/test/Bytecode/invalid/invalid-structure.mlir b/mlir/test/Bytecode/invalid/invalid-structure.mlir
index 661ccb17dbf3c..5f71ba7a3e681 100644
--- a/mlir/test/Bytecode/invalid/invalid-structure.mlir
+++ b/mlir/test/Bytecode/invalid/invalid-structure.mlir
@@ -2,7 +2,7 @@
 // a bytecode file.
 
 // Bytecode currently does not support big-endian platforms
-// XFAIL: s390x-
+// UNSUPPORTED: s390x-
 
 //===--------------------------------------------------------------------===//
 // Version

diff  --git a/mlir/test/Bytecode/invalid/invalid_attr_type_offset_section.mlir b/mlir/test/Bytecode/invalid/invalid_attr_type_offset_section.mlir
index 708448181c18f..46d192ebc70ef 100644
--- a/mlir/test/Bytecode/invalid/invalid_attr_type_offset_section.mlir
+++ b/mlir/test/Bytecode/invalid/invalid_attr_type_offset_section.mlir
@@ -2,7 +2,7 @@
 // the attribute/type offset section.
 
 // Bytecode currently does not support big-endian platforms
-// XFAIL: s390x-
+// UNSUPPORTED: s390x-
 
 //===--------------------------------------------------------------------===//
 // Offset

diff  --git a/mlir/test/Bytecode/invalid/invalid_attr_type_section.mlir b/mlir/test/Bytecode/invalid/invalid_attr_type_section.mlir
index 137ff75a13f8f..cad9a39805a9a 100644
--- a/mlir/test/Bytecode/invalid/invalid_attr_type_section.mlir
+++ b/mlir/test/Bytecode/invalid/invalid_attr_type_section.mlir
@@ -2,7 +2,7 @@
 // the attribute/type offset section.
 
 // Bytecode currently does not support big-endian platforms
-// XFAIL: s390x-
+// UNSUPPORTED: s390x-
 
 //===--------------------------------------------------------------------===//
 // Index