[Mlir-commits] [mlir] 96fd3f2 - [mlir:Bytecode] Fix asan failure

[River Riddle]

Author: River Riddle
Date: 2022-08-22T10:02:42-07:00
New Revision: 96fd3f2d5be21ded6ffed0ac75195df04ec679df

URL: https://github.com/llvm/llvm-project/commit/96fd3f2d5be21ded6ffed0ac75195df04ec679df
DIFF: https://github.com/llvm/llvm-project/commit/96fd3f2d5be21ded6ffed0ac75195df04ec679df.diff

LOG: [mlir:Bytecode] Fix asan failure

We were accessing the region state after it got popped from the stack.

Added: 
    

Modified: 
    mlir/lib/Bytecode/Reader/BytecodeReader.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Bytecode/Reader/BytecodeReader.cpp b/mlir/lib/Bytecode/Reader/BytecodeReader.cpp
index cbb971910b69..7df545871842 100644
--- a/mlir/lib/Bytecode/Reader/BytecodeReader.cpp
+++ b/mlir/lib/Bytecode/Reader/BytecodeReader.cpp
@@ -921,9 +921,9 @@ BytecodeReader::parseRegions(EncodingReader &reader,
 
   // When the regions have been fully parsed, pop them off of the read stack. If
   // the regions were isolated from above, we also pop the last value scope.
-  regionStack.pop_back();
   if (readState.isIsolatedFromAbove)
     valueScopes.pop_back();
+  regionStack.pop_back();
   return success();
 }