[Mlir-commits] [mlir] 3a6da9e - [mlir] Remove redundant member initialization (NFC)
Kazu Hirata
llvmlistbot at llvm.org
Sun Aug 14 12:52:16 PDT 2022
Author: Kazu Hirata
Date: 2022-08-14T12:51:59-07:00
New Revision: 3a6da9ebcbaadfbd46b42e3168bb56b833fd9b28
URL: https://github.com/llvm/llvm-project/commit/3a6da9ebcbaadfbd46b42e3168bb56b833fd9b28
DIFF: https://github.com/llvm/llvm-project/commit/3a6da9ebcbaadfbd46b42e3168bb56b833fd9b28.diff
LOG: [mlir] Remove redundant member initialization (NFC)
Identified with readability-redundant-member-init.
Added:
Modified:
mlir/include/mlir/Dialect/Linalg/Transforms/CodegenStrategy.h
mlir/include/mlir/Dialect/Transform/IR/TransformInterfaces.h
mlir/include/mlir/Support/Timing.h
mlir/lib/Analysis/SliceAnalysis.cpp
mlir/lib/Dialect/Affine/Analysis/NestedMatcher.cpp
mlir/lib/Dialect/Arithmetic/Transforms/Bufferize.cpp
mlir/lib/Dialect/Bufferization/Transforms/Bufferize.cpp
mlir/lib/Dialect/Bufferization/Transforms/TensorCopyInsertion.cpp
mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp
mlir/lib/Dialect/SPIRV/IR/SPIRVTypes.cpp
mlir/lib/Dialect/SparseTensor/Transforms/DenseBufferizationPass.cpp
mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
mlir/lib/Dialect/SparseTensor/Utils/Merger.cpp
mlir/test/lib/Dialect/Test/TestTypes.h
Removed:
################################################################################
diff --git a/mlir/include/mlir/Dialect/Linalg/Transforms/CodegenStrategy.h b/mlir/include/mlir/Dialect/Linalg/Transforms/CodegenStrategy.h
index cc1f655414b89..82a49487458a8 100644
--- a/mlir/include/mlir/Dialect/Linalg/Transforms/CodegenStrategy.h
+++ b/mlir/include/mlir/Dialect/Linalg/Transforms/CodegenStrategy.h
@@ -128,7 +128,7 @@ struct Decompose : public Transformation {
struct Peel : public Transformation {
explicit Peel(linalg::LinalgPeelOptions options,
LinalgTransformationFilter::FilterFunction f = nullptr)
- : Transformation(std::move(f)), opName(), options(options) {}
+ : Transformation(std::move(f)), options(options) {}
Peel(StringRef name, linalg::LinalgPeelOptions options,
LinalgTransformationFilter::FilterFunction f = nullptr)
@@ -149,7 +149,7 @@ struct Vectorize : public Transformation {
explicit Vectorize(linalg::LinalgVectorizationOptions options,
LinalgTransformationFilter::FilterFunction f = nullptr,
bool padVectorize = false)
- : Transformation(std::move(f)), opName(), options(options),
+ : Transformation(std::move(f)), options(options),
vectorizePadding(padVectorize) {}
Vectorize(StringRef name, linalg::LinalgVectorizationOptions options,
diff --git a/mlir/include/mlir/Dialect/Transform/IR/TransformInterfaces.h b/mlir/include/mlir/Dialect/Transform/IR/TransformInterfaces.h
index d7dcd84477c96..61143cbf8a6fc 100644
--- a/mlir/include/mlir/Dialect/Transform/IR/TransformInterfaces.h
+++ b/mlir/include/mlir/Dialect/Transform/IR/TransformInterfaces.h
@@ -156,7 +156,7 @@ class [[nodiscard]] DiagnosedSilenceableFailure {
private:
explicit DiagnosedSilenceableFailure(Diagnostic &&diagnostic)
- : diagnostics(), result(failure()) {
+ : result(failure()) {
diagnostics.emplace_back(std::move(diagnostic));
}
explicit DiagnosedSilenceableFailure(SmallVector<Diagnostic> &&diagnostics)
diff --git a/mlir/include/mlir/Support/Timing.h b/mlir/include/mlir/Support/Timing.h
index 8c48536fe8695..e33fba5c13f41 100644
--- a/mlir/include/mlir/Support/Timing.h
+++ b/mlir/include/mlir/Support/Timing.h
@@ -270,7 +270,7 @@ class Timer {
/// started and stopped.
class TimingScope {
public:
- TimingScope() : timer() {}
+ TimingScope() {}
TimingScope(const Timer &other) : timer(other) {
if (timer)
timer.start();
diff --git a/mlir/lib/Analysis/SliceAnalysis.cpp b/mlir/lib/Analysis/SliceAnalysis.cpp
index 6a1d39786199f..e343c47bb0f01 100644
--- a/mlir/lib/Analysis/SliceAnalysis.cpp
+++ b/mlir/lib/Analysis/SliceAnalysis.cpp
@@ -161,8 +161,7 @@ namespace {
/// We traverse all operations but only record the ones that appear in
/// `toSort` for the final result.
struct DFSState {
- DFSState(const SetVector<Operation *> &set)
- : toSort(set), topologicalCounts(), seen() {}
+ DFSState(const SetVector<Operation *> &set) : toSort(set), seen() {}
const SetVector<Operation *> &toSort;
SmallVector<Operation *, 16> topologicalCounts;
DenseSet<Operation *> seen;
diff --git a/mlir/lib/Dialect/Affine/Analysis/NestedMatcher.cpp b/mlir/lib/Dialect/Affine/Analysis/NestedMatcher.cpp
index 8fc30a3ef3227..0ba6f59d02508 100644
--- a/mlir/lib/Dialect/Affine/Analysis/NestedMatcher.cpp
+++ b/mlir/lib/Dialect/Affine/Analysis/NestedMatcher.cpp
@@ -56,12 +56,12 @@ void NestedPattern::freeNested() {
NestedPattern::NestedPattern(ArrayRef<NestedPattern> nested,
FilterFunctionType filter)
- : nestedPatterns(), filter(std::move(filter)), skip(nullptr) {
+ : filter(std::move(filter)), skip(nullptr) {
copyNestedToThis(nested);
}
NestedPattern::NestedPattern(const NestedPattern &other)
- : nestedPatterns(), filter(other.filter), skip(other.skip) {
+ : filter(other.filter), skip(other.skip) {
copyNestedToThis(other.nestedPatterns);
}
diff --git a/mlir/lib/Dialect/Arithmetic/Transforms/Bufferize.cpp b/mlir/lib/Dialect/Arithmetic/Transforms/Bufferize.cpp
index 3237b1a880441..60c644e0e8c36 100644
--- a/mlir/lib/Dialect/Arithmetic/Transforms/Bufferize.cpp
+++ b/mlir/lib/Dialect/Arithmetic/Transforms/Bufferize.cpp
@@ -24,8 +24,7 @@ namespace {
struct ArithmeticBufferizePass
: public ArithmeticBufferizeBase<ArithmeticBufferizePass> {
ArithmeticBufferizePass(uint64_t alignment = 0, bool constantOpOnly = false)
- : ArithmeticBufferizeBase<ArithmeticBufferizePass>(),
- constantOpOnly(constantOpOnly) {
+ : constantOpOnly(constantOpOnly) {
this->alignment = alignment;
}
diff --git a/mlir/lib/Dialect/Bufferization/Transforms/Bufferize.cpp b/mlir/lib/Dialect/Bufferization/Transforms/Bufferize.cpp
index 10c6d6e65de5d..e6d38953ba638 100644
--- a/mlir/lib/Dialect/Bufferization/Transforms/Bufferize.cpp
+++ b/mlir/lib/Dialect/Bufferization/Transforms/Bufferize.cpp
@@ -165,7 +165,7 @@ parseLayoutMapOption(const std::string &s) {
struct OneShotBufferizePass
: public OneShotBufferizeBase<OneShotBufferizePass> {
- OneShotBufferizePass() : OneShotBufferizeBase<OneShotBufferizePass>() {}
+ OneShotBufferizePass() {}
explicit OneShotBufferizePass(const OneShotBufferizationOptions &options)
: options(options) {}
diff --git a/mlir/lib/Dialect/Bufferization/Transforms/TensorCopyInsertion.cpp b/mlir/lib/Dialect/Bufferization/Transforms/TensorCopyInsertion.cpp
index 275238a776a1f..8e5aa1cbc8072 100644
--- a/mlir/lib/Dialect/Bufferization/Transforms/TensorCopyInsertion.cpp
+++ b/mlir/lib/Dialect/Bufferization/Transforms/TensorCopyInsertion.cpp
@@ -160,11 +160,9 @@ mlir::bufferization::insertTensorCopies(Operation *op,
namespace {
struct TensorCopyInsertionPass
: TensorCopyInsertionBase<TensorCopyInsertionPass> {
- TensorCopyInsertionPass()
- : TensorCopyInsertionBase<TensorCopyInsertionPass>(),
- options(llvm::None) {}
+ TensorCopyInsertionPass() : options(llvm::None) {}
TensorCopyInsertionPass(const OneShotBufferizationOptions &options)
- : TensorCopyInsertionBase<TensorCopyInsertionPass>(), options(options) {}
+ : options(options) {}
void getDependentDialects(DialectRegistry ®istry) const override {
registry.insert<bufferization::BufferizationDialect>();
diff --git a/mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp b/mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp
index 2247fc5d97d0a..11152f177be19 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp
@@ -59,8 +59,7 @@ mlir::linalg::LinalgTransformationFilter::LinalgTransformationFilter(
mlir::linalg::LinalgTransformationFilter::LinalgTransformationFilter(
const FilterFunction &f, ArrayRef<StringAttr> matchDisjunction,
Optional<StringAttr> replacement)
- : filters(),
- matchDisjunction(matchDisjunction.begin(), matchDisjunction.end()),
+ : matchDisjunction(matchDisjunction.begin(), matchDisjunction.end()),
replacement(replacement), matchByDefault(false) {
if (f)
filters.push_back(f);
diff --git a/mlir/lib/Dialect/SPIRV/IR/SPIRVTypes.cpp b/mlir/lib/Dialect/SPIRV/IR/SPIRVTypes.cpp
index 353f6e29f1ce2..03a45b8c3884a 100644
--- a/mlir/lib/Dialect/SPIRV/IR/SPIRVTypes.cpp
+++ b/mlir/lib/Dialect/SPIRV/IR/SPIRVTypes.cpp
@@ -797,7 +797,7 @@ struct spirv::detail::StructTypeStorage : public TypeStorage {
StructType::MemberDecorationInfo const *memberDecorationsInfo)
: memberTypesAndIsBodySet(memberTypes, false), offsetInfo(layoutInfo),
numMembers(numMembers), numMemberDecorations(numMemberDecorations),
- memberDecorationsInfo(memberDecorationsInfo), identifier(StringRef()) {}
+ memberDecorationsInfo(memberDecorationsInfo) {}
/// A storage key is divided into 2 parts:
/// - for identified structs:
@@ -1076,7 +1076,7 @@ llvm::hash_code spirv::hash_value(
struct spirv::detail::MatrixTypeStorage : public TypeStorage {
MatrixTypeStorage(Type columnType, uint32_t columnCount)
- : TypeStorage(), columnType(columnType), columnCount(columnCount) {}
+ : columnType(columnType), columnCount(columnCount) {}
using KeyTy = std::tuple<Type, uint32_t>;
diff --git a/mlir/lib/Dialect/SparseTensor/Transforms/DenseBufferizationPass.cpp b/mlir/lib/Dialect/SparseTensor/Transforms/DenseBufferizationPass.cpp
index 51e18be6ff21a..49a882f31dccd 100644
--- a/mlir/lib/Dialect/SparseTensor/Transforms/DenseBufferizationPass.cpp
+++ b/mlir/lib/Dialect/SparseTensor/Transforms/DenseBufferizationPass.cpp
@@ -36,8 +36,7 @@ class BufferizeDenseOpsPass
public:
BufferizeDenseOpsPass(
const bufferization::OneShotBufferizationOptions &options)
- : PassWrapper<BufferizeDenseOpsPass, OperationPass<ModuleOp>>(),
- options(options) {}
+ : options(options) {}
void runOnOperation() override {
// Disallow all sparse tensor ops, so that only dense tensor ops are
diff --git a/mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp b/mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
index aab003b57efff..e5714c6a5cdf6 100644
--- a/mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
+++ b/mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
@@ -61,9 +61,8 @@ struct CodeGen {
indices(numTensors, std::vector<Value>(numLoops)),
highs(numTensors, std::vector<Value>(numLoops)),
pidxs(numTensors, std::vector<Value>(numLoops)),
- idxs(numTensors, std::vector<Value>(numLoops)), redVal(), sparseOut(op),
- outerParNest(nest), lexIdx(), lexVal(), expValues(), expFilled(),
- expAdded(), expCount(), curVecMask() {}
+ idxs(numTensors, std::vector<Value>(numLoops)), sparseOut(op),
+ outerParNest(nest) {}
/// Sparsification options.
SparsificationOptions options;
/// Universal dense indices and upper bounds (by index). The loops array
diff --git a/mlir/lib/Dialect/SparseTensor/Utils/Merger.cpp b/mlir/lib/Dialect/SparseTensor/Utils/Merger.cpp
index e691cb44e2656..a5e7a37776c95 100644
--- a/mlir/lib/Dialect/SparseTensor/Utils/Merger.cpp
+++ b/mlir/lib/Dialect/SparseTensor/Utils/Merger.cpp
@@ -122,12 +122,11 @@ TensorExp::TensorExp(Kind k, unsigned x, unsigned y, Value v, Operation *o)
}
LatPoint::LatPoint(unsigned n, unsigned e, unsigned b)
- : bits(n, false), simple(), exp(e) {
+ : bits(n, false), exp(e) {
bits.set(b);
}
-LatPoint::LatPoint(const BitVector &b, unsigned e)
- : bits(b), simple(), exp(e) {}
+LatPoint::LatPoint(const BitVector &b, unsigned e) : bits(b), exp(e) {}
//===----------------------------------------------------------------------===//
// Lattice methods.
diff --git a/mlir/test/lib/Dialect/Test/TestTypes.h b/mlir/test/lib/Dialect/Test/TestTypes.h
index f3cee52365598..ad1a8a2e7ce35 100644
--- a/mlir/test/lib/Dialect/Test/TestTypes.h
+++ b/mlir/test/lib/Dialect/Test/TestTypes.h
@@ -101,8 +101,7 @@ namespace test {
struct TestRecursiveTypeStorage : public ::mlir::TypeStorage {
using KeyTy = ::llvm::StringRef;
- explicit TestRecursiveTypeStorage(::llvm::StringRef key)
- : name(key), body(::mlir::Type()) {}
+ explicit TestRecursiveTypeStorage(::llvm::StringRef key) : name(key) {}
bool operator==(const KeyTy &other) const { return name == other; }
More information about the Mlir-commits
mailing list