[Mlir-commits] [mlir] 0e051c0 - Revert "[mlir][test] Fix IR/AttributeTest.cpp compilation on Solaris"

Mehdi Amini llvmlistbot at llvm.org
Thu Aug 4 11:48:28 PDT 2022


Author: Mehdi Amini
Date: 2022-08-04T18:48:22Z
New Revision: 0e051c02d51da2898240b52289c0d1e80d631132

URL: https://github.com/llvm/llvm-project/commit/0e051c02d51da2898240b52289c0d1e80d631132
DIFF: https://github.com/llvm/llvm-project/commit/0e051c02d51da2898240b52289c0d1e80d631132.diff

LOG: Revert "[mlir][test] Fix IR/AttributeTest.cpp compilation on Solaris"

This reverts commit 07aaa35f74d845a20d48e644671dce150ebf7748.

This breaks the Windows bot, and while the fix addressed the
`char`/`int8_t` case, it does not make sense for other cases like
`float`.

Added: 
    

Modified: 
    mlir/unittests/IR/AttributeTest.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/unittests/IR/AttributeTest.cpp b/mlir/unittests/IR/AttributeTest.cpp
index 098ce3849a606..8250afd3cb971 100644
--- a/mlir/unittests/IR/AttributeTest.cpp
+++ b/mlir/unittests/IR/AttributeTest.cpp
@@ -219,8 +219,8 @@ template <typename AttrT, typename T>
 static void checkNativeAccess(MLIRContext *ctx, ArrayRef<T> data,
                               Type elementType) {
   auto type = RankedTensorType::get(data.size(), elementType);
-  auto attr = AttrT::get(type, "resource",
-                         UnmanagedAsmResourceBlob::allocate(data, alignof(T)));
+  auto attr =
+      AttrT::get(type, "resource", UnmanagedAsmResourceBlob::allocate(data));
 
   // Check that we can access and iterate the data properly.
   Optional<ArrayRef<T>> attrData = attr.tryGetAsArrayRef();


        


More information about the Mlir-commits mailing list