[Mlir-commits] [mlir] f1033a3 - [mlir][Math] Add constant folder for TanOp.

[llvmlistbot at llvm.org]

Author: jacquesguan
Date: 2022-08-02T11:20:53+08:00
New Revision: f1033a3f47da1bdd757bf596fee8bdaa64dfe925

URL: https://github.com/llvm/llvm-project/commit/f1033a3f47da1bdd757bf596fee8bdaa64dfe925
DIFF: https://github.com/llvm/llvm-project/commit/f1033a3f47da1bdd757bf596fee8bdaa64dfe925.diff

LOG: [mlir][Math] Add constant folder for TanOp.

This patch adds constant folder for TanOp which only supports single and double precision floating-point.

Differential Revision: https://reviews.llvm.org/D130873

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/Math/IR/MathOps.td
    mlir/lib/Dialect/Math/IR/MathOps.cpp
    mlir/test/Dialect/Math/canonicalize.mlir

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/Math/IR/MathOps.td b/mlir/include/mlir/Dialect/Math/IR/MathOps.td
index 75b8782d1d4e..70bdf09a85dd 100644
--- a/mlir/include/mlir/Dialect/Math/IR/MathOps.td
+++ b/mlir/include/mlir/Dialect/Math/IR/MathOps.td
@@ -656,6 +656,7 @@ def Math_TanOp : Math_FloatUnaryOp<"tan"> {
     %a = math.tan %b : f64
     ```
   }];
+  let hasFolder = 1;
 }
 
 //===----------------------------------------------------------------------===//

diff  --git a/mlir/lib/Dialect/Math/IR/MathOps.cpp b/mlir/lib/Dialect/Math/IR/MathOps.cpp
index 2ba640b796b2..ad3c1b031d36 100644
--- a/mlir/lib/Dialect/Math/IR/MathOps.cpp
+++ b/mlir/lib/Dialect/Math/IR/MathOps.cpp
@@ -264,6 +264,24 @@ OpFoldResult math::ExpM1Op::fold(ArrayRef<Attribute> operands) {
       });
 }
 
+//===----------------------------------------------------------------------===//
+// TanOp folder
+//===----------------------------------------------------------------------===//
+
+OpFoldResult math::TanOp::fold(ArrayRef<Attribute> operands) {
+  return constFoldUnaryOpConditional<FloatAttr>(
+      operands, [](const APFloat &a) -> Optional<APFloat> {
+        switch (a.getSizeInBits(a.getSemantics())) {
+        case 64:
+          return APFloat(tan(a.convertToDouble()));
+        case 32:
+          return APFloat(tanf(a.convertToFloat()));
+        default:
+          return {};
+        }
+      });
+}
+
 /// Materialize an integer or floating point constant.
 Operation *math::MathDialect::materializeConstant(OpBuilder &builder,
                                                   Attribute value, Type type,

diff  --git a/mlir/test/Dialect/Math/canonicalize.mlir b/mlir/test/Dialect/Math/canonicalize.mlir
index dfd1e5748e5c..8ed20b7fb969 100644
--- a/mlir/test/Dialect/Math/canonicalize.mlir
+++ b/mlir/test/Dialect/Math/canonicalize.mlir
@@ -282,3 +282,23 @@ func.func @expm1_fold_vec() -> (vector<4xf32>) {
   %0 = math.expm1 %v1 : vector<4xf32>
   return %0 : vector<4xf32>
 }
+
+
+// CHECK-LABEL: @tan_fold
+// CHECK-NEXT: %[[cst:.+]] = arith.constant 1.55740774 : f32
+// CHECK-NEXT:   return %[[cst]]
+func.func @tan_fold() -> f32 {
+  %c = arith.constant 1.0 : f32
+  %r = math.tan %c : f32
+  return %r : f32
+}
+
+// CHECK-LABEL: @tan_fold_vec
+// CHECK-NEXT: %[[cst:.+]] = arith.constant dense<[0.000000e+00, 1.55740774, 0.000000e+00, 1.55740774]> : vector<4xf32>
+// CHECK-NEXT:   return %[[cst]]
+func.func @tan_fold_vec() -> (vector<4xf32>) {
+  %v1 = arith.constant dense<[0.0, 1.0, 0.0, 1.0]> : vector<4xf32>
+  %0 = math.tan %v1 : vector<4xf32>
+  return %0 : vector<4xf32>
+}
+