[Mlir-commits] [mlir] 93b23c8 - Apply clang-tidy fixes for llvm-else-after-return in SCF.cpp (NFC)

Mehdi Amini llvmlistbot at llvm.org
Wed Apr 13 16:15:02 PDT 2022


Author: Mehdi Amini
Date: 2022-04-13T23:14:44Z
New Revision: 93b23c84399bd9f95332ebcbc170ea6edadd404e

URL: https://github.com/llvm/llvm-project/commit/93b23c84399bd9f95332ebcbc170ea6edadd404e
DIFF: https://github.com/llvm/llvm-project/commit/93b23c84399bd9f95332ebcbc170ea6edadd404e.diff

LOG: Apply clang-tidy fixes for llvm-else-after-return in SCF.cpp (NFC)

Added: 
    

Modified: 
    mlir/lib/Dialect/SCF/SCF.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/SCF/SCF.cpp b/mlir/lib/Dialect/SCF/SCF.cpp
index 3e5028f247a09..f010bc658b663 100644
--- a/mlir/lib/Dialect/SCF/SCF.cpp
+++ b/mlir/lib/Dialect/SCF/SCF.cpp
@@ -1793,9 +1793,8 @@ struct CombineNestedIfs : public OpRewritePattern<IfOp> {
       // If the then value is defined within the scf.if, bail.
       if (tup.value().getParentRegion() == &op.getThenRegion()) {
         return failure();
-      } else {
-        elseYieldsToUpgradeToSelect.push_back(tup.index());
       }
+      elseYieldsToUpgradeToSelect.push_back(tup.index());
     }
 
     Location loc = op.getLoc();


        


More information about the Mlir-commits mailing list