[Mlir-commits] [mlir] 20aedb1 - [MLIR][Presburger] Remove inheritance from PresburgerSpace in IntegerRelation, PresburgerRelation and PWMAFunction

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Apr 12 10:21:55 PDT 2022


Author: Groverkss
Date: 2022-04-12T22:48:52+05:30
New Revision: 20aedb148b85c6f44a86081b9d737444ede5cda3

URL: https://github.com/llvm/llvm-project/commit/20aedb148b85c6f44a86081b9d737444ede5cda3
DIFF: https://github.com/llvm/llvm-project/commit/20aedb148b85c6f44a86081b9d737444ede5cda3.diff

LOG: [MLIR][Presburger] Remove inheritance from PresburgerSpace in IntegerRelation, PresburgerRelation and PWMAFunction

This patch removes inheritence from PresburgerSpace in IntegerRelation and
instead makes it a member of these classes.

This is required for three reasons:
  - It prevents implicit casting to PresburgerSpace.
  - Not all functions of PresburgerSpace need to be exposed by the deriving classes.
  - IntegerRelation and IntegerPolyhedron are defined in a PresburgerSpace. It
    makes more sense for the space to be a member instead of them inheriting from
    a space.

Reviewed By: arjunp, ftynse

Differential Revision: https://reviews.llvm.org/D123585

Added: 
    

Modified: 
    mlir/include/mlir/Analysis/Presburger/IntegerRelation.h
    mlir/include/mlir/Analysis/Presburger/PWMAFunction.h
    mlir/include/mlir/Analysis/Presburger/PresburgerRelation.h
    mlir/include/mlir/Analysis/Presburger/PresburgerSpace.h
    mlir/include/mlir/Dialect/Affine/Analysis/AffineStructures.h
    mlir/lib/Analysis/Presburger/IntegerRelation.cpp
    mlir/lib/Analysis/Presburger/PWMAFunction.cpp
    mlir/lib/Analysis/Presburger/PresburgerRelation.cpp
    mlir/lib/Analysis/Presburger/PresburgerSpace.cpp

Removed: 
    


################################################################################error: too big or took too long to generate

        


More information about the Mlir-commits mailing list