[Mlir-commits] [mlir] 6984845 - [MLIR][Presburger] Make the SimplexBase constructor protected

Arjun P llvmlistbot at llvm.org
Sat Apr 2 03:30:27 PDT 2022


Author: Arjun P
Date: 2022-04-02T12:30:23+01:00
New Revision: 698484549a53e9a9e98673fcc377671ec41419e1

URL: https://github.com/llvm/llvm-project/commit/698484549a53e9a9e98673fcc377671ec41419e1
DIFF: https://github.com/llvm/llvm-project/commit/698484549a53e9a9e98673fcc377671ec41419e1.diff

LOG: [MLIR][Presburger] Make the SimplexBase constructor protected

This is not supposed to be instantiated directly anyway.

Reviewed By: Groverkss

Differential Revision: https://reviews.llvm.org/D122923

Added: 
    

Modified: 
    mlir/include/mlir/Analysis/Presburger/Simplex.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Analysis/Presburger/Simplex.h b/mlir/include/mlir/Analysis/Presburger/Simplex.h
index e1a8bf2a471ff..ba974c0ccbb32 100644
--- a/mlir/include/mlir/Analysis/Presburger/Simplex.h
+++ b/mlir/include/mlir/Analysis/Presburger/Simplex.h
@@ -153,15 +153,6 @@ class SimplexBase {
   SimplexBase() = delete;
   virtual ~SimplexBase() = default;
 
-  /// Construct a SimplexBase with the specified number of variables and fixed
-  /// columns.
-  ///
-  /// For example, Simplex uses two fixed columns: the denominator and the
-  /// constant term, whereas LexSimplex has an extra fixed column for the
-  /// so-called big M parameter. For more information see the documentation for
-  /// LexSimplex.
-  SimplexBase(unsigned nVar, bool mustUseBigM);
-
   /// Returns true if the tableau is empty (has conflicting constraints),
   /// false otherwise.
   bool isEmpty() const;
@@ -213,6 +204,15 @@ class SimplexBase {
   void dump() const;
 
 protected:
+  /// Construct a SimplexBase with the specified number of variables and fixed
+  /// columns.
+  ///
+  /// For example, Simplex uses two fixed columns: the denominator and the
+  /// constant term, whereas LexSimplex has an extra fixed column for the
+  /// so-called big M parameter. For more information see the documentation for
+  /// LexSimplex.
+  SimplexBase(unsigned nVar, bool mustUseBigM);
+
   enum class Orientation { Row, Column };
 
   /// An Unknown is either a variable or a constraint. It is always associated


        


More information about the Mlir-commits mailing list