[Mlir-commits] [mlir] 2189548 - [mlir][sparse] Correcting a few typos

wren romano llvmlistbot at llvm.org
Thu Sep 30 11:42:59 PDT 2021


Author: wren romano
Date: 2021-09-30T11:42:46-07:00
New Revision: 218954865ebee18d3d3f119a8579b9c1a6396c0b

URL: https://github.com/llvm/llvm-project/commit/218954865ebee18d3d3f119a8579b9c1a6396c0b
DIFF: https://github.com/llvm/llvm-project/commit/218954865ebee18d3d3f119a8579b9c1a6396c0b.diff

LOG: [mlir][sparse] Correcting a few typos

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D110773

Added: 
    

Modified: 
    mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorConversion.cpp
    mlir/lib/ExecutionEngine/SparseUtils.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorConversion.cpp b/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorConversion.cpp
index 681c8160aaeaa..cd6fea5355928 100644
--- a/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorConversion.cpp
+++ b/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorConversion.cpp
@@ -1,4 +1,4 @@
-//===- SparseTensorLowering.cpp - Sparse tensor primitives conversion -----===//
+//===- SparseTensorConversion.cpp - Sparse tensor primitives conversion ---===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -363,7 +363,7 @@ class SparseTensorConvertConverter : public OpConversionPattern<ConvertOp> {
     auto encSrc = getSparseTensorEncoding(op.source().getType());
     if (encDst && encSrc) {
       // This is a sparse => sparse conversion, which is handled as follows:
-      //   t = src->asCOO();         ; src to COO in dst order
+      //   t = src->toCOO();         ; src to COO in dst order
       //   dst = newSparseTensor(t)
       // Using the coordinate scheme as an intermediate does not always
       // yield the fastest conversion but avoids the need for a full

diff  --git a/mlir/lib/ExecutionEngine/SparseUtils.cpp b/mlir/lib/ExecutionEngine/SparseUtils.cpp
index 6a5943dc6acc7..77cff107124c7 100644
--- a/mlir/lib/ExecutionEngine/SparseUtils.cpp
+++ b/mlir/lib/ExecutionEngine/SparseUtils.cpp
@@ -674,7 +674,6 @@ IMPL3(addEltI32, int32_t)
 IMPL3(addEltI16, int16_t)
 IMPL3(addEltI8, int8_t)
 
-#undef TEMPLATE
 #undef CASE
 #undef IMPL1
 #undef IMPL2


        


More information about the Mlir-commits mailing list