[Mlir-commits] [mlir] 61bc6aa - [mlir] spelling and style changes in ReconcileUnrealizedCasts.cpp. NFC.

[Alex Zinenko]

Author: Alex Zinenko
Date: 2021-09-10T14:09:29+02:00
New Revision: 61bc6aa5a723438198ba8526b0469ff11b47c489

URL: https://github.com/llvm/llvm-project/commit/61bc6aa5a723438198ba8526b0469ff11b47c489
DIFF: https://github.com/llvm/llvm-project/commit/61bc6aa5a723438198ba8526b0469ff11b47c489.diff

LOG: [mlir] spelling and style changes in ReconcileUnrealizedCasts.cpp. NFC.

Added: 
    

Modified: 
    mlir/lib/Conversion/ReconcileUnrealizedCasts/ReconcileUnrealizedCasts.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Conversion/ReconcileUnrealizedCasts/ReconcileUnrealizedCasts.cpp b/mlir/lib/Conversion/ReconcileUnrealizedCasts/ReconcileUnrealizedCasts.cpp
index 92dc69a8dbdc7..3e75908077822 100644
--- a/mlir/lib/Conversion/ReconcileUnrealizedCasts/ReconcileUnrealizedCasts.cpp
+++ b/mlir/lib/Conversion/ReconcileUnrealizedCasts/ReconcileUnrealizedCasts.cpp
@@ -1,4 +1,4 @@
-//===- ReoncileUnrealizedCasts.cpp - Eliminate noop unrealized casts ------===//
+//===- ReconcileUnrealizedCasts.cpp - Eliminate noop unrealized casts -----===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -32,15 +32,16 @@ struct UnrealizedConversionCastPassthrough
 
   LogicalResult matchAndRewrite(UnrealizedConversionCastOp op,
                                 PatternRewriter &rewriter) const override {
+    // Match the casts that are _only_ used by other casts, with the overall
+    // cast being a trivial noop: A->B->A.
     auto users = op->getUsers();
     if (!llvm::all_of(users, [&](Operation *user) {
-          if (auto other = dyn_cast<UnrealizedConversionCastOp>(user)) {
+          if (auto other = dyn_cast<UnrealizedConversionCastOp>(user))
             return other.getResultTypes() == op.inputs().getTypes() &&
                    other.inputs() == op.outputs();
-          }
           return false;
         })) {
-      return rewriter.notifyMatchFailure(op, "live unrealized conversion");
+      return rewriter.notifyMatchFailure(op, "live unrealized conversion cast");
     }
 
     for (Operation *user : users)
@@ -52,8 +53,9 @@ struct UnrealizedConversionCastPassthrough
 };
 
 /// Pass to simplify and eliminate unrealized conversion casts.
-struct FinalizeToLLVM : public ReconcileUnrealizedCastsBase<FinalizeToLLVM> {
-  FinalizeToLLVM() = default;
+struct ReconcileUnrealizedCasts
+    : public ReconcileUnrealizedCastsBase<ReconcileUnrealizedCasts> {
+  ReconcileUnrealizedCasts() = default;
 
   void runOnOperation() override {
     RewritePatternSet patterns(&getContext());
@@ -74,5 +76,5 @@ void mlir::populateReconcileUnrealizedCastsPatterns(
 }
 
 std::unique_ptr<Pass> mlir::createReconcileUnrealizedCastsPass() {
-  return std::make_unique<FinalizeToLLVM>();
+  return std::make_unique<ReconcileUnrealizedCasts>();
 }