[Mlir-commits] [mlir] 8e54f24 - Disable add_mlir_aggregate() debug file generation.

[Stella Laurenzo]

Author: Stella Laurenzo
Date: 2021-10-14T14:32:27-07:00
New Revision: 8e54f24f89c5c5e1d7ba4a4d2b99118272ac27ef

URL: https://github.com/llvm/llvm-project/commit/8e54f24f89c5c5e1d7ba4a4d2b99118272ac27ef
DIFF: https://github.com/llvm/llvm-project/commit/8e54f24f89c5c5e1d7ba4a4d2b99118272ac27ef.diff

LOG: Disable add_mlir_aggregate() debug file generation.

* Leaves it as a commented out area with a note on how to debug.

Added: 
    

Modified: 
    mlir/cmake/modules/AddMLIR.cmake

Removed: 
    


################################################################################
diff  --git a/mlir/cmake/modules/AddMLIR.cmake b/mlir/cmake/modules/AddMLIR.cmake
index 823f4281cab44..8441e4c3474de 100644
--- a/mlir/cmake/modules/AddMLIR.cmake
+++ b/mlir/cmake/modules/AddMLIR.cmake
@@ -339,18 +339,21 @@ function(add_mlir_aggregate name)
   if(MSVC)
     set_property(TARGET ${name} PROPERTY WINDOWS_EXPORT_ALL_SYMBOLS ON)
   endif()
-  string(APPEND _debugmsg
-    ": MAIN LIBRARY:\n"
-    "    OBJECTS = ${_objects}\n"
-    "    SOURCES = $<TARGET_GENEX_EVAL:${name},$<TARGET_PROPERTY:${name},SOURCES>>\n"
-    "    DEPS = ${_deps}\n"
-    "    LINK_LIBRARIES = $<TARGET_GENEX_EVAL:${name},$<TARGET_PROPERTY:${name},LINK_LIBRARIES>>\n"
-    "    MLIR_AGGREGATE_EXCLUDE_LIBS = $<TARGET_GENEX_EVAL:${name},$<TARGET_PROPERTY:${name},MLIR_AGGREGATE_EXCLUDE_LIBS>>\n"
-  )
-  file(GENERATE OUTPUT
-    "${CMAKE_CURRENT_BINARY_DIR}/${name}.aggregate_debug.txt"
-    CONTENT "${_debugmsg}"
-  )
+
+  # Debugging generator expressions can be hard. Uncomment the below to emit
+  # files next to the library with a lot of debug information:
+  # string(APPEND _debugmsg
+  #   ": MAIN LIBRARY:\n"
+  #   "    OBJECTS = ${_objects}\n"
+  #   "    SOURCES = $<TARGET_GENEX_EVAL:${name},$<TARGET_PROPERTY:${name},SOURCES>>\n"
+  #   "    DEPS = ${_deps}\n"
+  #   "    LINK_LIBRARIES = $<TARGET_GENEX_EVAL:${name},$<TARGET_PROPERTY:${name},LINK_LIBRARIES>>\n"
+  #   "    MLIR_AGGREGATE_EXCLUDE_LIBS = $<TARGET_GENEX_EVAL:${name},$<TARGET_PROPERTY:${name},MLIR_AGGREGATE_EXCLUDE_LIBS>>\n"
+  # )
+  # file(GENERATE OUTPUT
+  #   "${CMAKE_CURRENT_BINARY_DIR}/${name}.aggregate_debug.txt"
+  #   CONTENT "${_debugmsg}"
+  # )
 endfunction(add_mlir_aggregate)
 
 # Adds an MLIR library target for installation.