[Mlir-commits] [mlir] d023298 - [MLIR] Fix unused tablegen template arg warnings

Cullen Rhodes llvmlistbot at llvm.org
Mon Oct 4 03:23:53 PDT 2021


Author: Cullen Rhodes
Date: 2021-10-04T10:22:39Z
New Revision: d023298b61b32231540bb626492c906c5aa5bf2c

URL: https://github.com/llvm/llvm-project/commit/d023298b61b32231540bb626492c906c5aa5bf2c
DIFF: https://github.com/llvm/llvm-project/commit/d023298b61b32231540bb626492c906c5aa5bf2c.diff

LOG: [MLIR] Fix unused tablegen template arg warnings

Identified in D109359.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D110805

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/Tosa/IR/TosaTypesBase.td
    mlir/include/mlir/IR/OpBase.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/Tosa/IR/TosaTypesBase.td b/mlir/include/mlir/Dialect/Tosa/IR/TosaTypesBase.td
index f9cb12b208646..c2888ea56dd80 100644
--- a/mlir/include/mlir/Dialect/Tosa/IR/TosaTypesBase.td
+++ b/mlir/include/mlir/Dialect/Tosa/IR/TosaTypesBase.td
@@ -149,7 +149,7 @@ class Tosa_TypeLike<list<Type> types, string description = ""> : TypeConstraint<
      AnyTypeOf<types>.predicate,
      VectorOf<types>.predicate,
      TensorOf<types>.predicate]>,
-     "signless-integer-32-like">;
+     description>;
 
 def Tosa_Int8Like : Tosa_TypeLike<[Tosa_Int8], "signless-integer-8-bit-like">;
 def Tosa_Int16Like : Tosa_TypeLike<[Tosa_Int16], "signless-integer-16-bit-like">;

diff  --git a/mlir/include/mlir/IR/OpBase.td b/mlir/include/mlir/IR/OpBase.td
index d5ec098224571..403f4b7029424 100644
--- a/mlir/include/mlir/IR/OpBase.td
+++ b/mlir/include/mlir/IR/OpBase.td
@@ -2083,8 +2083,7 @@ class TypeInterface<string name> : Interface<name>, InterfaceTrait<name>;
 // declarations should be generated. This class takes an optional set of methods
 // that should have declarations generated even if the method has a default
 // implementation.
-class DeclareInterfaceMethods<Interface interface,
-                              list<string> overridenMethods = []> {
+class DeclareInterfaceMethods<list<string> overridenMethods = []> {
     // This field contains a set of method names that should always have their
     // declarations generated. This allows for generating declarations for
     // methods with default implementations that need to be overridden.
@@ -2092,7 +2091,7 @@ class DeclareInterfaceMethods<Interface interface,
 }
 class DeclareAttrInterfaceMethods<AttrInterface interface,
                                   list<string> overridenMethods = []>
-      : DeclareInterfaceMethods<interface, overridenMethods>,
+      : DeclareInterfaceMethods<overridenMethods>,
         AttrInterface<interface.cppClassName> {
     let description = interface.description;
     let cppClassName = interface.cppClassName;
@@ -2101,7 +2100,7 @@ class DeclareAttrInterfaceMethods<AttrInterface interface,
 }
 class DeclareOpInterfaceMethods<OpInterface interface,
                                 list<string> overridenMethods = []>
-      : DeclareInterfaceMethods<interface, overridenMethods>,
+      : DeclareInterfaceMethods<overridenMethods>,
         OpInterface<interface.cppClassName> {
     let description = interface.description;
     let cppClassName = interface.cppClassName;
@@ -2110,7 +2109,7 @@ class DeclareOpInterfaceMethods<OpInterface interface,
 }
 class DeclareTypeInterfaceMethods<TypeInterface interface,
                                   list<string> overridenMethods = []>
-      : DeclareInterfaceMethods<interface, overridenMethods>,
+      : DeclareInterfaceMethods<overridenMethods>,
         TypeInterface<interface.cppClassName> {
     let description = interface.description;
     let cppClassName = interface.cppClassName;


        


More information about the Mlir-commits mailing list