[Mlir-commits] [mlir] 467acf3 - [mlir][spirv] Float atomics should not imply Shader

[llvmlistbot at llvm.org]

Author: Butygin
Date: 2021-11-25T12:07:28+03:00
New Revision: 467acf3b6ba27858801e8a7865a315455b92c0ee

URL: https://github.com/llvm/llvm-project/commit/467acf3b6ba27858801e8a7865a315455b92c0ee
DIFF: https://github.com/llvm/llvm-project/commit/467acf3b6ba27858801e8a7865a315455b92c0ee.diff

LOG: [mlir][spirv] Float atomics should not imply Shader

Differential Revision: https://reviews.llvm.org/D114551

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td
index 5429cf8c79320..b3ca8c74b56bf 100644
--- a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td
+++ b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td
@@ -1210,19 +1210,22 @@ def SPV_C_IntegerFunctions2INTEL                      : I32EnumAttrCase<"Integer
   ];
 }
 def SPV_C_AtomicFloat32AddEXT                         : I32EnumAttrCase<"AtomicFloat32AddEXT", 6033> {
-  list<I32EnumAttrCase> implies = [SPV_C_Shader];
+  // Float atomics also supported in kernels (https://github.com/KhronosGroup/SPIRV-Headers/pull/257).
+  // list<I32EnumAttrCase> implies = [SPV_C_Shader];
   list<Availability> availability = [
     Extension<[SPV_EXT_shader_atomic_float_add]>
   ];
 }
 def SPV_C_AtomicFloat64AddEXT                         : I32EnumAttrCase<"AtomicFloat64AddEXT", 6034> {
-  list<I32EnumAttrCase> implies = [SPV_C_Shader];
+  // Float atomics also supported in kernels (https://github.com/KhronosGroup/SPIRV-Headers/pull/257).
+  // list<I32EnumAttrCase> implies = [SPV_C_Shader];
   list<Availability> availability = [
     Extension<[SPV_EXT_shader_atomic_float_add]>
   ];
 }
 def SPV_C_AtomicFloat16AddEXT                         : I32EnumAttrCase<"AtomicFloat16AddEXT", 6095> {
-  list<I32EnumAttrCase> implies = [SPV_C_Shader];
+  // Float atomics also supported in kernels (https://github.com/KhronosGroup/SPIRV-Headers/pull/257).
+  // list<I32EnumAttrCase> implies = [SPV_C_Shader];
   list<Availability> availability = [
     Extension<[SPV_EXT_shader_atomic_float16_add]>
   ];