[Mlir-commits] [mlir] 8bd08a9 - [MLIR] Remove duplicate `Pass` suffix from ViewOpGraph class name

Uday Bondhugula llvmlistbot at llvm.org
Tue Nov 23 18:31:01 PST 2021


Author: Uday Bondhugula
Date: 2021-11-24T08:00:16+05:30
New Revision: 8bd08a9fd705dce07d7cd76711532432b575ed78

URL: https://github.com/llvm/llvm-project/commit/8bd08a9fd705dce07d7cd76711532432b575ed78
DIFF: https://github.com/llvm/llvm-project/commit/8bd08a9fd705dce07d7cd76711532432b575ed78.diff

LOG: [MLIR] Remove duplicate `Pass` suffix from ViewOpGraph class name

Remove duplicate `Pass` suffix from view-op-graph pass class name. The
extra suffix would lead to methods like registerViewOpGraphPassPass
being generated.

Differential Revision: https://reviews.llvm.org/D114459

Added: 
    

Modified: 
    mlir/include/mlir/Transforms/Passes.td
    mlir/lib/Transforms/ViewOpGraph.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Transforms/Passes.td b/mlir/include/mlir/Transforms/Passes.td
index df06c0bb6532e..0dede70b3b87c 100644
--- a/mlir/include/mlir/Transforms/Passes.td
+++ b/mlir/include/mlir/Transforms/Passes.td
@@ -692,7 +692,7 @@ def SymbolDCE : Pass<"symbol-dce"> {
   let constructor = "mlir::createSymbolDCEPass()";
 }
 
-def ViewOpGraphPass : Pass<"view-op-graph"> {
+def ViewOpGraph : Pass<"view-op-graph"> {
   let summary = "Print Graphviz visualization of an operation";
   let description = [{
     This pass prints a Graphviz graph of a module.

diff  --git a/mlir/lib/Transforms/ViewOpGraph.cpp b/mlir/lib/Transforms/ViewOpGraph.cpp
index 044136c454bd9..365779494e48e 100644
--- a/mlir/lib/Transforms/ViewOpGraph.cpp
+++ b/mlir/lib/Transforms/ViewOpGraph.cpp
@@ -68,7 +68,7 @@ struct Node {
 /// This pass generates a Graphviz dataflow visualization of an MLIR operation.
 /// Note: See https://www.graphviz.org/doc/info/lang.html for more information
 /// about the Graphviz DOT language.
-class PrintOpPass : public ViewOpGraphPassBase<PrintOpPass> {
+class PrintOpPass : public ViewOpGraphBase<PrintOpPass> {
 public:
   PrintOpPass(raw_ostream &os) : os(os) {}
   PrintOpPass(const PrintOpPass &o) : PrintOpPass(o.os.getOStream()) {}


        


More information about the Mlir-commits mailing list