[Mlir-commits] [mlir] 2290a80 - [mlir][NFC] Remove illegal TanhOp in LLVMConversionTarget

[Tres Popp]

Author: Tres Popp
Date: 2021-05-31T10:40:09+02:00
New Revision: 2290a80b4dcbeb230ea47ea59b00205ccefbaa96

URL: https://github.com/llvm/llvm-project/commit/2290a80b4dcbeb230ea47ea59b00205ccefbaa96
DIFF: https://github.com/llvm/llvm-project/commit/2290a80b4dcbeb230ea47ea59b00205ccefbaa96.diff

LOG: [mlir][NFC] Remove illegal TanhOp in LLVMConversionTarget

No tests fail and this seems to be technical debt from when the math
dialect was created. This should not be there as it prevents users from
configuring their converion target freely and results in unexpected
behavior on seemingly unrelated ops.

Differential Revision: https://reviews.llvm.org/D103388

Added: 
    

Modified: 
    mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp b/mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
index 2fbfa1103aa39..6ddc333a011c0 100644
--- a/mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
+++ b/mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
@@ -4132,7 +4132,6 @@ mlir::LLVMConversionTarget::LLVMConversionTarget(MLIRContext &ctx)
     : ConversionTarget(ctx) {
   this->addLegalDialect<LLVM::LLVMDialect>();
   this->addIllegalOp<LLVM::DialectCastOp>();
-  this->addIllegalOp<math::TanhOp>();
 }
 
 std::unique_ptr<OperationPass<ModuleOp>> mlir::createLowerToLLVMPass() {